Skip to content

feat(generator): Universalize constraints path and grpcio requirement in gapic-generator templates#17251

Closed
chalmerlowe wants to merge 6 commits into
mainfrom
feat/universal-generator-fixes
Closed

feat(generator): Universalize constraints path and grpcio requirement in gapic-generator templates#17251
chalmerlowe wants to merge 6 commits into
mainfrom
feat/universal-generator-fixes

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

This PR updates the Python GAPIC generator templates to support modern EOL Python support drops natively across the entire SDK.

Changes

  • setup.py.j2: Bumps the baseline minimum grpcio dependency requirement to >= 1.59.0. This robust minimum requirement resolves the pytest-asyncio event loop regressions universally, removing the need for custom pytest-asyncio overrides.
  • noxfile.py.j2: Replaced the hardcoded constraints path with a dynamic constraints file path resolver at runtime, ensuring that monorepos natively resolve to their version-specific constraints files (e.g., testing/constraints-3.10.txt).

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum version of grpcio to 1.59.0 in setup.py.j2 and conditionally sets the LOWER_BOUND_CONSTRAINTS_FILE path in noxfile.py.j2 based on the existence of a testing directory. A review comment suggests making the constraints file path resolution more robust by checking for the existence of the specific versioned constraints file directly instead of just checking for the testing directory.

Comment thread packages/gapic-generator/gapic/templates/noxfile.py.j2
@chalmerlowe chalmerlowe added this to the generate via 1.32.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant