feat(generator): Universalize constraints path and grpcio requirement in gapic-generator templates#17251
Closed
chalmerlowe wants to merge 6 commits into
Closed
feat(generator): Universalize constraints path and grpcio requirement in gapic-generator templates#17251chalmerlowe wants to merge 6 commits into
chalmerlowe wants to merge 6 commits into
Conversation
… in gapic-generator templates
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum version of grpcio to 1.59.0 in setup.py.j2 and conditionally sets the LOWER_BOUND_CONSTRAINTS_FILE path in noxfile.py.j2 based on the existence of a testing directory. A review comment suggests making the constraints file path resolution more robust by checking for the existence of the specific versioned constraints file directly instead of just checking for the testing directory.
…emplates and integration goldens
…ldens with grpcio 1.59.0
…yncio loop RuntimeError in unit tests
…-rest constraints template
…vent loop fixture and async-rest constraints updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Python GAPIC generator templates to support modern EOL Python support drops natively across the entire SDK.
Changes
grpciodependency requirement to>= 1.59.0. This robust minimum requirement resolves thepytest-asyncioevent loop regressions universally, removing the need for custompytest-asynciooverrides.testing/constraints-3.10.txt).