Skip to content

feat(firestore): drop Python 3.7-3.9 support and regenerate #17247

Merged
chalmerlowe merged 11 commits into
mainfrom
fix-firestore-FTL-1.32.0
May 26, 2026
Merged

feat(firestore): drop Python 3.7-3.9 support and regenerate #17247
chalmerlowe merged 11 commits into
mainfrom
fix-firestore-FTL-1.32.0

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe commented May 26, 2026

This PR updates python to establish version 3.10 as the minimum supported version.

Changes

  • Configuration & Dependencies:

    • Updated the Python support matrix and classifiers across setup.py, noxfile.py, and CONTRIBUTING.rst to require Python >= 3.10.
    • Regenerated and synchronized EOL runtime constraints files.
    • Cleaned up and pruned obsolete warning filters inside pytest.ini that were previously used for Python < 3.10.
  • Test Suite Enhancements:

    • Refactored test_pipeline_explain_options_explain_mode inside both test_system.py and test_system_async.py.
    • Previously, the tests expected an InvalidArgument exception since Explain mode wasn't supported on pipeline queries. Since the live backend now natively supports Explain mode on Pipeline queries, the tests were updated to assert successful plan metrics execution and verify that the correct ExplainStats protobuf structures are returned.
  • Librarian Generator Post-Processing:

    • Configured and integrated permanent EOL post-processing rules directly inside .librarian/generator-input/client-post-processing/firestore-integration.yaml to ensure that all future gapic-generator runs automatically preserve these EOL constraints changes and avoid generator overwrites.

@chalmerlowe chalmerlowe requested review from a team as code owners May 26, 2026 11:10
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.7, 3.8, and 3.9 across the google-cloud-firestore package, updating the minimum supported version to Python 3.10. The changes include updates to the documentation, pytest configurations, and testing constraints. The review feedback points out that when updating Python versions in documentation examples (such as nox commands in CONTRIBUTING.rst), the current stable release version (e.g., 3.12) should be used instead of the minimum supported version (3.10) or a pre-release version (3.14) to ensure examples remain relevant and functional for most developers.

Comment thread packages/google-cloud-firestore/CONTRIBUTING.rst
Comment thread packages/google-cloud-firestore/CONTRIBUTING.rst
@parthea parthea self-assigned this May 26, 2026
Copy link
Copy Markdown
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit b11224f into main May 26, 2026
34 checks passed
@chalmerlowe chalmerlowe deleted the fix-firestore-FTL-1.32.0 branch May 26, 2026 20:03
@chalmerlowe chalmerlowe added this to the generate via 1.32.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants