feat(firestore): drop Python 3.7-3.9 support and regenerate #17247
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request drops support for Python 3.7, 3.8, and 3.9 across the google-cloud-firestore package, updating the minimum supported version to Python 3.10. The changes include updates to the documentation, pytest configurations, and testing constraints. The review feedback points out that when updating Python versions in documentation examples (such as nox commands in CONTRIBUTING.rst), the current stable release version (e.g., 3.12) should be used instead of the minimum supported version (3.10) or a pre-release version (3.14) to ensure examples remain relevant and functional for most developers.
…or live backend compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates python to establish version 3.10 as the minimum supported version.
Changes
Configuration & Dependencies:
setup.py,noxfile.py, andCONTRIBUTING.rstto require Python>= 3.10.pytest.inithat were previously used for Python < 3.10.Test Suite Enhancements:
test_pipeline_explain_options_explain_modeinside bothtest_system.pyandtest_system_async.py.InvalidArgumentexception since Explain mode wasn't supported on pipeline queries. Since the live backend now natively supports Explain mode on Pipeline queries, the tests were updated to assert successful plan metrics execution and verify that the correctExplainStatsprotobuf structures are returned.Librarian Generator Post-Processing:
.librarian/generator-input/client-post-processing/firestore-integration.yamlto ensure that all future gapic-generator runs automatically preserve these EOL constraints changes and avoid generator overwrites.