Skip to content

feat(firestore): support object functions#16132

Draft
Linchin wants to merge 1 commit intogoogleapis:mainfrom
Linchin:fs-object
Draft

feat(firestore): support object functions#16132
Linchin wants to merge 1 commit intogoogleapis:mainfrom
Linchin:fs-object

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Mar 19, 2026

  • map_set()

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Firestore's expression capabilities by introducing the map_set function. This new feature allows for programmatic updates or additions of key-value pairs within map fields directly through pipeline expressions, providing greater flexibility and control over data manipulation within documents.

Highlights

  • New map_set function: Introduced the map_set method to the Expression class in pipeline_expressions.py, allowing users to add or update key-value pairs within map fields using Firestore expressions.
  • Unit Tests: Added comprehensive unit tests for the map_set function in test_pipeline_expressions.py to ensure its correct behavior and integration.
  • System Tests: Included a new end-to-end system test case in map.yaml to validate the functionality of map_set within a complete Firestore pipeline.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the map_set function in Firestore pipeline expressions, including the implementation, a system test, and a unit test. The changes are well-structured and the tests cover the new functionality appropriately. I have one minor suggestion to fix a typo in the docstring for consistency.

updated.

Note:
`mapSet` only performs shallow updates to the map. Setting a value to `None`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a small typo in the docstring. The function is named map_set (snake_case), but it's referred to as mapSet (camelCase) here. For consistency with the function name and Python conventions, it should be map_set.

Suggested change
`mapSet` only performs shallow updates to the map. Setting a value to `None`
`map_set` only performs shallow updates to the map. Setting a value to `None`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant