Sample migration PR: test-20260319T095810#16131
Open
jskeet wants to merge 7 commits intogoogleapis:mainfrom
Open
Sample migration PR: test-20260319T095810#16131jskeet wants to merge 7 commits intogoogleapis:mainfrom
jskeet wants to merge 7 commits intogoogleapis:mainfrom
Conversation
These are primarily due to legacylibrarian running the post-processor in a clean context, whereas librarian runs it with existing handwritten code in place.
This is just to get legacylibrarian up to HEAD in googleapis. There will not be an equivalent of this commit in the real migration.
Generated with:
```sh
for file in packages/*/.repo-metadata.json
do
jq 'del(.requires_billing)' $file | \
jq 'del(.codeowner_team)' | \
jq --sort-keys . | \
jq 'del(..|select(. == ""))' | \
jq --indent 4 > tmp.json
truncate -s -1 tmp.json
mv tmp.json $file
sed -i 's/&/\\u0026/g' $file
done
```
(This won't be in the real "big" PR, as we'll already have a genuine librarian.yaml file with the first two libraries.)
(This should include .librarian/config.yaml changes, and future test PRs will do so.)
This was performed by running `nox -s format --no-venv --no-install` and ignoring errors created by the few libraries which don't have a "format" session.
See PR description for a breakdown of these.
jskeet
added
the
do not merge
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sample migration PR. It demonstrates what we expect to see during migration, hopefully in a way that is easy to review commit-by-commit.
Expected changes in the last commit:
Unexpected changes in the last commit, which need work: