feat(google/spanner/v1): onboard a new library#8860
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/spanner-api package, which provides auto-generated Node.js clients for Cloud Spanner, including database administration, instance administration, and core Spanner services. Feedback on the changes highlights that the generated instance_admin_client.ts file is missing from the PR, and the entrypoint files currently only export InstanceAdminClient instead of all generated clients. Additionally, it is recommended to update the package description in package.json to be more generic and accurate.
| // ** https://github.com/googleapis/gapic-generator-typescript ** | ||
| // ** All changes to this file may be overwritten. ** | ||
|
|
||
| export { InstanceAdminClient } from './instance_admin_client'; |
There was a problem hiding this comment.
The file instance_admin_client.ts is missing from this pull request. Please do not manually edit this generated TypeScript client file to add the exports. Any changes or updates must be made upstream in the generator to ensure all client files are generated and exported correctly.
References
- Do not manually edit generated TypeScript client files. Any changes or updates must be made upstream in the generator.
| const InstanceAdminClient = v1.InstanceAdminClient; | ||
| type InstanceAdminClient = v1.InstanceAdminClient; | ||
|
|
||
| export {v1, InstanceAdminClient}; | ||
| export default {v1, InstanceAdminClient}; |
There was a problem hiding this comment.
This entrypoint file only imports and exports InstanceAdminClient. Please do not manually edit this generated TypeScript client file to add the missing exports. Any changes or updates to export all the generated clients must be made upstream in the generator.
References
- Do not manually edit generated TypeScript client files. Any changes or updates must be made upstream in the generator.
| { | ||
| "name": "@google-cloud/spanner-api", | ||
| "version": "0.1.0", | ||
| "description": "Instance client for Node.js", |
There was a problem hiding this comment.
The package description is currently set to 'Instance client for Node.js'. Since this package is a combined Spanner API package containing multiple clients (including database admin, instance admin, and the core Spanner client), the description should be updated to be more generic and accurate.
| "description": "Instance client for Node.js", | |
| "description": "Cloud Spanner API client for Node.js", |
1 participant
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕