feat(google/devtools/clouderrorreporting/v1beta1): onboard a new library#8858
feat(google/devtools/clouderrorreporting/v1beta1): onboard a new library#8858quirogas wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/error-reporting-api package, which is a Node.js client for the Google Cloud Error Reporting API. It includes the auto-generated client libraries, protocol buffers, samples, tests, and configuration files. The review feedback highlights a few issues: a version mismatch in librarian.yaml (set to 1.0.0 instead of 0.1.0), incorrect repository paths in the generated README.md links, and an overly specific library name (ErrorGroupService) in the Webpack configuration that should be generalized to ErrorReporting since the package contains multiple services.
| nodejs: | ||
| default_version: v1 | ||
| - name: google-cloud-error-reporting-api | ||
| version: 1.0.0 |
There was a problem hiding this comment.
The version of the library is set to 1.0.0 here, but in package.json it is initialized as 0.1.0. Since this is a new library onboarding in the preview release stage, the version should be 0.1.0 to maintain consistency across the configuration files and prevent issues in the release pipeline.
version: 0.1.0| copyright_year: "2026" | ||
| nodejs: | ||
| default_version: v1 | ||
| - name: google-cloud-error-reporting-api |
There was a problem hiding this comment.
The package directory is named google-cloud-error-reporting-api, but the auto-generated README.md contains links pointing to packages/google-devtools-clouderrorreporting (e.g., homepage_samples, homepage_changelog, and homepage). Please check if there is a generator configuration or template issue that causes this mismatch, or if the library name/directory needs to be aligned upstream.
| library: 'ErrorGroupService', | ||
| filename: './error-group-service.js', |
There was a problem hiding this comment.
The webpack configuration defines the library name as ErrorGroupService and the output filename as ./error-group-service.js. Since this package @google-cloud/error-reporting-api contains multiple services (ErrorGroupService, ErrorStatsService, and ReportErrorsService), using a generic name like ErrorReporting and ./error-reporting.js is more appropriate and accurate.
| library: 'ErrorGroupService', | |
| filename: './error-group-service.js', | |
| library: 'ErrorReporting', | |
| filename: './error-reporting.js', |
1 participant
No description provided.