feat(storage): add x-goog-gcs-idempotency-token header#8837
Open
thiyaguk09 wants to merge 7 commits into
Open
Conversation
product-auto-label
Bot
added
the
api: storage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces changes to align the x-goog-gcs-idempotency-token header with the gccl-invocation-id across various request types, including standard service requests and resumable uploads. It also respects user-provided idempotency tokens case-insensitively. The review feedback highlights a critical issue in resumable-upload.ts where user-provided customRequestOptions.headers are mutated directly. This can lead to unexpected side effects or runtime errors if the options object is frozen. It is recommended to clone the options and headers objects before modifying them.
…-invocation-id for request tracking
…e with gccl-invocation-id header
…ining for idempotency token access
…k to generating a UUID
… token to prevent conflicts
…al logic during resumable uploads
…ing shared header objects
thiyaguk09
force-pushed
the
feat/idempotency-tokens
branch
from
5a6aa6e to
46f25f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕