fix!: Update storage to use newer versions of gaxios, teeny-request, and google-auth-library

[pearigee]

These newer versions required code changes to be compatible, specifically changes to how headers are handled.

[gemini-code-assist]

Code Review

This pull request updates dependency versions and refactors header handling in resumable-upload.ts and transfer-manager.ts to support different header formats (such as Headers instances, arrays, and plain objects), alongside updating corresponding tests. The code review feedback correctly identifies a case-sensitivity bug in the new getResponseHeader helper and points out that checking for non-Headers and non-array types before setting headers can cause critical metadata and encryption headers to be silently ignored. The reviewer suggests implementing robust getResponseHeader and setHeader helper functions to safely handle all header formats consistently.

[gemini-code-assist]

The current implementation of getResponseHeader has a case-sensitivity bug when headers is a plain object. For example, if name is 'location' and the object contains { Location: '...' }, both headers?.[name] and headers?.[name.toLowerCase()] will look up 'location' and return undefined.

Additionally, throughout this file, headers are conditionally set only if reqOpts.headers is not an instance of Headers and not an array. If reqOpts.headers is a Headers object or an array, these headers (including critical encryption headers) are silently ignored.

Let's define robust getResponseHeader and setHeader helper functions at the top of the file to handle all header types (Headers object, array of entries, or plain object) correctly.

function getResponseHeader(headers: any, name: string): string | undefined {
  if (!headers) return undefined;
  if (typeof headers.get === 'function') {
    return headers.get(name) || undefined;
  }
  if (Array.isArray(headers)) {
    const entry = headers.find(h => h[0].toLowerCase() === name.toLowerCase());
    return entry ? entry[1] : undefined;
  }
  const key = Object.keys(headers).find(k => k.toLowerCase() === name.toLowerCase());
  return key ? headers[key] : undefined;
}

function setHeader(headers: any, name: string, value: string): void {
  if (!headers) return;
  if (typeof headers.set === 'function') {
    headers.set(name, value);
  } else if (Array.isArray(headers)) {
    const index = headers.findIndex(h => h[0].toLowerCase() === name.toLowerCase());
    if (index !== -1) {
      headers[index][1] = value;
    } else {
      headers.push([name, value]);
    }
  } else {
    headers[name] = value;
  }
}

[gemini-code-assist]

Use the new setHeader helper to safely set the upload headers regardless of whether reqOpts.headers is a plain object, a Headers instance, or an array.

    if (reqOpts.headers) {
      if (metadata.contentLength) {
        setHeader(reqOpts.headers, 'X-Upload-Content-Length', metadata.contentLength.toString());
      }

      if (metadata.contentType) {
        setHeader(reqOpts.headers, 'X-Upload-Content-Type', metadata.contentType);
      }
    }

[gemini-code-assist]

Use the setHeader helper to safely set the Origin header.

      if (reqOpts.headers) {
        setHeader(reqOpts.headers, 'Origin', this.origin);
      }

[gemini-code-assist]

Use the setHeader helper to safely set the encryption headers. This ensures customer-supplied encryption keys (CSEK) are not silently ignored if reqOpts.headers is a Headers instance or an array.

      reqOpts.headers = reqOpts.headers || {};
      setHeader(reqOpts.headers, 'x-goog-encryption-algorithm', 'AES256');
      setHeader(reqOpts.headers, 'x-goog-encryption-key', this.encryption.key.toString());
      setHeader(reqOpts.headers, 'x-goog-encryption-key-sha256', this.encryption.hash.toString());