Skip to content

fix(storage): bump retry-request and teeny-request#7958

Open
OfriHarlev wants to merge 1 commit intogoogleapis:mainfrom
OfriHarlev:ofri/fix-storage-request-stack
Open

fix(storage): bump retry-request and teeny-request#7958
OfriHarlev wants to merge 1 commit intogoogleapis:mainfrom
OfriHarlev:ofri/fix-storage-request-stack

Conversation

@OfriHarlev
Copy link
Copy Markdown

@OfriHarlev OfriHarlev commented Apr 4, 2026

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #7838

Description

This updates the handwritten @google-cloud/storage package off the older request stack by bumping:

  • retry-request from ^7.0.0 to ^8.0.0
  • teeny-request from ^9.0.0 to ^10.0.0

For the storage package itself, that changes the resolved runtime chain from:
retry-request@7 -> teeny-request@9 -> http-proxy-agent@5 -> @tootallnate/once@2

to:
retry-request@8.0.2 -> teeny-request@10.1.2 -> http-proxy-agent@7.0.2

This matters because consumers of @google-cloud/storage currently inherit the older http-proxy-agent@5 / @tootallnate/once@2 path, which is called out in GHSA-vpq2-c234-7xj6.

Impact

No source code changes were needed for this bump.

handwritten/storage already uses retry-request and teeny-request through the existing request helpers in src/nodejs-common, and the direct API surface used by the package remained compatible with the newer dependency line in this package-level validation. In practice, this is a dependency-resolution update rather than a behavior change in storage's own code.

One scope note: this does not remove every http-proxy-agent@5 occurrence from the monorepo dependency graph. After the bump, the remaining vulnerable path in this package install is through the dev dependency @google-cloud/pubsub -> google-gax@4.6.1 -> retry-request@7 -> teeny-request@9. This PR is specifically for the handwritten storage package's direct runtime request stack.

Testing

I validated this change inside handwritten/storage in the active google-cloud-node monorepo layout:

  • npm install
  • npx mocha build/cjs/test/nodejs-common/service.js build/cjs/test/nodejs-common/util.js
    • Result on upstream main: 151 passing
    • Result on this branch: 151 passing
  • npm test
    • Result on upstream main: 3 failing
    • Result on this branch: 3 failing
    • The same three existing failures reproduce in both cases under File#createWriteStream:
      • should emit errors
      • should emit RangeError
      • should close upstream when pipeline fails
  • npm run lint
    • Result on upstream main: fails in this environment with existing Prettier/GTS formatting errors across the package
    • Result on this branch: same failure shape as upstream main

I also verified the resolved dependency tree after the bump:

  • retry-request@8.0.2
  • teeny-request@10.1.2
  • http-proxy-agent@7.0.2

Additional Information

If you want this issue fully closed at the monorepo level rather than the storage runtime path specifically, there is still follow-up work to move the remaining dev/test dependency branches off http-proxy-agent@5 as well.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 4, 2026
@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OfriHarlev OfriHarlev marked this pull request as ready for review April 4, 2026 23:19
@OfriHarlev OfriHarlev requested a review from a team as a code owner April 4, 2026 23:20
@OfriHarlev OfriHarlev force-pushed the ofri/fix-storage-request-stack branch from cb85b33 to e3097e6 Compare April 4, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

outdated http-proxy-agent version

1 participant