fix(storage): bump retry-request and teeny-request#7958
Open
OfriHarlev wants to merge 1 commit intogoogleapis:mainfrom
Open
fix(storage): bump retry-request and teeny-request#7958OfriHarlev wants to merge 1 commit intogoogleapis:mainfrom
OfriHarlev wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cb85b33 to
e3097e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7838
Description
This updates the handwritten
@google-cloud/storagepackage off the older request stack by bumping:retry-requestfrom^7.0.0to^8.0.0teeny-requestfrom^9.0.0to^10.0.0For the storage package itself, that changes the resolved runtime chain from:
retry-request@7 -> teeny-request@9 -> http-proxy-agent@5 -> @tootallnate/once@2to:
retry-request@8.0.2 -> teeny-request@10.1.2 -> http-proxy-agent@7.0.2This matters because consumers of
@google-cloud/storagecurrently inherit the olderhttp-proxy-agent@5/@tootallnate/once@2path, which is called out in GHSA-vpq2-c234-7xj6.Impact
No source code changes were needed for this bump.
handwritten/storagealready usesretry-requestandteeny-requestthrough the existing request helpers insrc/nodejs-common, and the direct API surface used by the package remained compatible with the newer dependency line in this package-level validation. In practice, this is a dependency-resolution update rather than a behavior change in storage's own code.One scope note: this does not remove every
http-proxy-agent@5occurrence from the monorepo dependency graph. After the bump, the remaining vulnerable path in this package install is through the dev dependency@google-cloud/pubsub -> google-gax@4.6.1 -> retry-request@7 -> teeny-request@9. This PR is specifically for the handwritten storage package's direct runtime request stack.Testing
I validated this change inside
handwritten/storagein the activegoogle-cloud-nodemonorepo layout:npm installnpx mocha build/cjs/test/nodejs-common/service.js build/cjs/test/nodejs-common/util.jsmain:151 passing151 passingnpm testmain:3 failing3 failingFile#createWriteStream:should emit errorsshould emit RangeErrorshould close upstream when pipeline failsnpm run lintmain: fails in this environment with existing Prettier/GTS formatting errors across the packagemainI also verified the resolved dependency tree after the bump:
retry-request@8.0.2teeny-request@10.1.2http-proxy-agent@7.0.2Additional Information
If you want this issue fully closed at the monorepo level rather than the storage runtime path specifically, there is still follow-up work to move the remaining dev/test dependency branches off
http-proxy-agent@5as well.