fix(gapic-bom): remove handwritten storage boms#12668
Closed
westarle wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix(gapic-bom): remove handwritten storage boms#12668westarle wants to merge 1 commit intogoogleapis:mainfrom
westarle wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Remove `google-cloud-nio-bom` and `google-cloud-storage-bom` from `gapic-libraries-bom/pom.xml`. These are handwritten clients that should be added to `java-cloud-bom/google-cloud-bom/pom.xml` instead. Since `java-storage` and `java-storage-nio` are in the Kokoro `excluded_modules` list, their snapshot BOMs are not installed to the local `.m2` repository during CI installation steps. When `CreateBomCanaryProject` validates `gapic-libraries-bom/pom.xml`, the failure to resolve these imported snapshot BOMs caused Maven to report missing versions for their underlying jars. This reverts their accidental inclusion introduced in commits: - 1da80e6 (google-cloud-nio-bom) - 5a4afb5 (google-cloud-storage-bom)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
google-cloud-nio-bomandgoogle-cloud-storage-bomfromgapic-libraries-bom/pom.xml. These are handwritten clients that should be added tojava-cloud-bom/google-cloud-bom/pom.xmlinstead. Sincejava-storageandjava-storage-nioare in the Kokoroexcluded_moduleslist, their snapshot BOMs are not installed to the local.m2repository during CI installation steps. WhenCreateBomCanaryProjectvalidatesgapic-libraries-bom/pom.xml, the failure to resolve these imported snapshot BOMs caused Maven to report missing versions for their underlying jars.This reverts their accidental inclusion introduced in commits: