tests: Update showcase test to include service name in resource extraction#12665
Open
tests: Update showcase test to include service name in resource extraction#12665
Conversation
blakeli0
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors OpenTelemetry integration tests by updating resource name constants and improving client initialization. Specifically, it updates the VALUE_TEST_USER constant to a fully qualified format and introduces helper methods and a custom stub settings class for the Identity service in ITOtelTracing.java to ensure the service name is correctly set. Additionally, the PR includes minor code style improvements, such as removing unused imports and reformatting long lines in ITOtelGoldenMetrics.java and TestClientInitializer.java. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates showcase test to include service name in resource name extraction.