Skip to content

chore: Simply renovate bot config to only propose testing and ci dep updates#12662

Draft
lqiu96 wants to merge 1 commit intomainfrom
update-renovate-config
Draft

chore: Simply renovate bot config to only propose testing and ci dep updates#12662
lqiu96 wants to merge 1 commit intomainfrom
update-renovate-config

Conversation

@lqiu96
Copy link
Copy Markdown
Member

@lqiu96 lqiu96 commented Apr 2, 2026

Leaving this as a draft to see if we want to use this. Port of the renovate PR in sdk-platform-java: googleapis/sdk-platform-java#4155

As part of dependency management policy, try not propose new deps upgrade. Any deps that need to be upgraded can be raised manually. This should also help with renovate bot quota and PR backlog management.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Renovate configuration to categorize dependencies into production, test, and build groups with specific semantic commit types, while also enabling the dependency dashboard and removing PR limits. Feedback includes a correction for an invalid regex pattern used to match all packages and highlights contradictions between the configuration and the PR's stated goals regarding production dependency updates and PR rate limiting.

Comment on lines +7 to +9
"matchPackagePatterns": [
"*"
]
],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The matchPackagePatterns field expects a valid regular expression. The string "*" is not a valid regex as it lacks a preceding atom for the quantifier. To match all packages, use matchPackageNames with the glob "*" or matchPackagePatterns with the regex ".*".

Suggested change
"matchPackagePatterns": [
"*"
]
],
"matchPackageNames": [
"*"
],

Comment on lines +13 to 21
"matchPackagePatterns": [
"^com.google.cloud:",
"^com.google.api:",
"^com.google.http-client:",
"^com.google.api-client:"
],
"enabled": true,
"semanticCommitType": "deps"
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This configuration block enables updates for production dependencies (e.g., com.google.cloud, com.google.api). This contradicts the pull request's stated objective of only proposing updates for testing and CI dependencies. If these production dependencies are intended to be managed manually, this block should be removed.

Comment on lines +145 to +146
"prConcurrentLimit": 0,
"prHourlyLimit": 0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting prConcurrentLimit and prHourlyLimit to 0 removes all limits on the number of PRs Renovate can create. This contradicts the PR description's goal of helping with 'renovate bot quota and PR backlog management'. To effectively manage the backlog and quota, consider setting these to a positive integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant