Skip to content

Comments

ci: build demo builds in debug mode#15988

Merged
scotthart merged 3 commits intogoogleapis:mainfrom
scotthart:ci_quickstart_debug_mode
Feb 20, 2026
Merged

ci: build demo builds in debug mode#15988
scotthart merged 3 commits intogoogleapis:mainfrom
scotthart:ci_quickstart_debug_mode

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Feb 20, 2026

This change is Reviewable

@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the debugging capabilities within the continuous integration (CI) demo environments. By configuring all demo builds to use the Debug build type, developers can obtain more detailed diagnostic information, such as symbols and unoptimized code, which is crucial for identifying and resolving issues. Additionally, an improvement to the gdb command ensures that comprehensive backtraces are collected when a quickstart program fails, further aiding in troubleshooting.

Highlights

  • CI Build Type Change: The CMAKE_BUILD_TYPE has been switched from Release to Debug across all demo build configurations, including the main demo-install.sh script and various Dockerfiles for different Linux distributions. This change applies to the main project build and several third-party dependencies.
  • GDB Command Update: The gdb command used in quickstart.sh for post-failure cleanup has been modified to use thread apply all bt instead of bt full, providing more comprehensive backtrace information for all threads.
Changelog
  • ci/cloudbuild/builds/demo-install.sh
    • Updated the CMAKE_BUILD_TYPE from Release to Debug for the main project build.
  • ci/cloudbuild/builds/lib/quickstart.sh
    • Modified the gdb command in the cleanup function to use thread apply all bt for more thorough backtrace collection.
  • ci/cloudbuild/dockerfiles/demo-debian-bookworm.Dockerfile
    • Updated CMAKE_BUILD_TYPE to Debug for abseil-cpp, protobuf, opentelemetry-cpp, c-ares, re2, and grpc builds.
  • ci/cloudbuild/dockerfiles/demo-debian-bullseye.Dockerfile
    • Updated CMAKE_BUILD_TYPE to Debug for abseil-cpp, protobuf, re2, grpc, and opentelemetry-cpp builds.
  • ci/cloudbuild/dockerfiles/demo-rockylinux-9.Dockerfile
    • Updated CMAKE_BUILD_TYPE to Debug for abseil-cpp, protobuf, re2, grpc, json, and opentelemetry-cpp builds.
  • ci/cloudbuild/dockerfiles/demo-ubuntu-24.04.Dockerfile
    • Updated CMAKE_BUILD_TYPE to Debug for abseil-cpp, protobuf, opentelemetry-cpp, c-ares, re2, and grpc builds.
  • ci/cloudbuild/dockerfiles/demo-ubuntu-jammy.Dockerfile
    • Updated CMAKE_BUILD_TYPE to Debug for abseil-cpp, protobuf, grpc, json, and opentelemetry-cpp builds.
  • doc/packaging.md
    • Updated CMAKE_BUILD_TYPE to Debug in various cmake commands for building google-cloud-cpp and its dependencies within the documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request changes the CMAKE_BUILD_TYPE from Release to Debug across multiple CMake configurations in various build scripts and Dockerfiles. This change is consistent with the PR title and description, aiming to build demo builds in debug mode. Additionally, the quickstart.sh script has been updated to use thread apply all bt with gdb for core dump analysis, which is a more comprehensive command for debugging multithreaded applications.

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.63%. Comparing base (c8a2a88) to head (62ff429).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15988   +/-   ##
=======================================
  Coverage   92.63%   92.63%           
=======================================
  Files        2334     2334           
  Lines      214633   214633           
=======================================
+ Hits       198822   198832   +10     
+ Misses      15811    15801   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart force-pushed the ci_quickstart_debug_mode branch from 12f75e9 to 23daee8 Compare February 20, 2026 21:19
@scotthart scotthart marked this pull request as ready for review February 20, 2026 21:23
@scotthart scotthart requested a review from a team as a code owner February 20, 2026 21:23
@scotthart scotthart enabled auto-merge (squash) February 20, 2026 23:35
@scotthart scotthart merged commit e23bcd2 into googleapis:main Feb 20, 2026
53 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants