ci: build demo builds in debug mode#15988
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the debugging capabilities within the continuous integration (CI) demo environments. By configuring all demo builds to use the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request changes the CMAKE_BUILD_TYPE from Release to Debug across multiple CMake configurations in various build scripts and Dockerfiles. This change is consistent with the PR title and description, aiming to build demo builds in debug mode. Additionally, the quickstart.sh script has been updated to use thread apply all bt with gdb for core dump analysis, which is a more comprehensive command for debugging multithreaded applications.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15988 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 2334 2334
Lines 214633 214633
=======================================
+ Hits 198822 198832 +10
+ Misses 15811 15801 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12f75e9 to
23daee8
Compare
This change is