fix(generator): omit empty services from require list and default service selection#1308
Open
aandreassa wants to merge 1 commit into
Open
fix(generator): omit empty services from require list and default service selection#1308aandreassa wants to merge 1 commit into
aandreassa wants to merge 1 commit into
Conversation
…vice selection Do not generate require statements in the package entry point for services with zero RPC methods, since their client files are skipped during generation. This causes a failure seen in googleapis/google-cloud-ruby#34675 Also, update `GemPresenter#first_non_common_service` to ignore empty services so they are not selected as primary services for Rakefile credentials setup and quickstart documentation.
aandreassa
force-pushed
the
empty-service-require-fix
branch
from
3e62d5d to
a19317b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not generate require statements in the package entry point for services with zero RPC methods, since their client files are skipped during generation.
This causes a failure seen in googleapis/google-cloud-ruby#34675
Also, update
GemPresenter#first_non_common_serviceto ignore empty services so they are not selected as primary services for Rakefile credentials setup and quickstart documentation.Currently, two libraries have 'empty' services.
google-cloud-dataplex-v1google-cloud-sql-v1A demo of updates generated locally can be seen in https://github.com/googleapis/google-cloud-ruby/pull/34726/changes
This PR is a follow-up from #1279