feat(wish): add TLS support (BoringSSL for now) + some tweaks#18
Merged
feat(wish): add TLS support (BoringSSL for now) + some tweaks#18
Conversation
tyoshino
commented
Feb 26, 2026
Comment on lines
+3
to
+12
| #include <event2/bufferevent_ssl.h> | ||
| #include <event2/dns.h> | ||
| #include <event2/event.h> | ||
| #include <openssl/ssl.h> | ||
|
|
||
| #include <cstring> | ||
| #include <iostream> | ||
| #include <string> | ||
|
|
||
| #include "../src/tls_context.h" |
Collaborator
Author
There was a problem hiding this comment.
adjusted include order to comply with Google C++ Style Guide. The same about the other files.
wish/cpp/examples/client.cc
Outdated
| event_base_free(base); | ||
|
|
||
| return 0; | ||
| // Initialize OpenSSL |
Collaborator
Author
There was a problem hiding this comment.
Oops, sorry, I included indentation formatting in this PR by mistake...
Collaborator
Author
There was a problem hiding this comment.
reverted indentation change to make it easier to review
| set(EVENT__DISABLE_MBEDTLS ON CACHE BOOL "" FORCE) | ||
|
|
||
| # Exclude tests, sample files, etc. that we don't need. | ||
| set(EVENT__DISABLE_BENCHMARKS ON CACHE BOOL "" FORCE) |
Collaborator
Author
There was a problem hiding this comment.
removing benchmark code, too
| GIT_TAG main | ||
| ) | ||
|
|
||
| # Disable OpenSSL and Mbed TLS. We use BoringSSL instead. |
tyoshino
commented
Feb 26, 2026
Collaborator
Author
There was a problem hiding this comment.
certificates and keys for testing generated by using openssl
tyoshino
changed the title
wenbozhu
reviewed
Feb 27, 2026
wish/cpp/src/tls_context.cc
Outdated
| } | ||
| } | ||
|
|
||
| void TlsContext::set_identity_certificate_path(const std::string& path) { identity_certificate_path_ = path; } |
Collaborator
There was a problem hiding this comment.
re: naming, let's follow openssl conventions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.