Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
signed CLA |
| #include "../src/wish_handler.h" | ||
|
|
||
| int main() { | ||
| struct event_base *base = event_base_new(); |
There was a problem hiding this comment.
Let me change the indentation to comply with the Google C++ Style Guide by a separate PR.
|
|
||
| FetchContent_Declare( | ||
| wslay | ||
| GIT_REPOSITORY https://github.com/tatsuhiro-t/wslay.git |
There was a problem hiding this comment.
I have a local patch on this not included in this PR that skips masking validation. I'll think about how to include it later.
There was a problem hiding this comment.
started with only CMake. good to have Bazel, too?
There was a problem hiding this comment.
Let's start with CMake. Ultimately we want this to work with the Python toolchain?
|
|
||
| FetchContent_Declare( | ||
| libevent | ||
| GIT_REPOSITORY https://github.com/libevent/libevent.git |
There was a problem hiding this comment.
started with libevent. We may want to revisit this after studying what to do with Python binding, etc.
There was a problem hiding this comment.
wish codec should be based on wslay ... and then it should work with any http client/server?
net_http's httpserver uses libevents for both I/O and http/1.1.
| GIT_TAG master | ||
| ) | ||
| # Disable OpenSSL and other heavy features for libevent to keep build fast/simple if possible | ||
| set(EVENT__DISABLE_OPENSSL ON CACHE BOOL "" FORCE) |
There was a problem hiding this comment.
@wenbozhu I guess this is what you mentioned in the meeting about disabling TLS.
It's generated code which I didn't take a close look. I'll review these.
2 participants
Spec: https://datatracker.ietf.org/doc/html/draft-yoshino-wish