Prepare to changes to var in AST#1342
Merged
copybara-service[bot] merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
After https://bugs.openjdk.org/browse/JDK-8268850, `VariableTree#getType` returns a new AST node `VarTypeTree` for variables declared with `var`. The new node could be handled in the visitor by implementing `visitVarType`, but that API is only available on the latest JDK versions using var, which would require creating a new version-specific visitor implementation. To defer doing that, this fix re-orders the logic that handles variable types to check if the next token is `var` first, to avoid needing to handle the new AST node. PiperOrigin-RevId: 876244813
copybara-service
bot
force-pushed
the
test_876115710
branch
from
416a9c7 to
075e025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare to changes to
varin ASTAfter https://bugs.openjdk.org/browse/JDK-8268850,
VariableTree#getTypereturns a new AST nodeVarTypeTreefor variables declared withvar.The new node could be handled in the visitor by implementing
visitVarType, but that API is only available on the latest JDK versions using var, which would require creating a new version-specific visitor implementation. To defer doing that, this fix re-orders the logic that handles variable types to check if the next token isvarfirst, to avoid needing to handle the new AST node.