-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add Issue Dependencies API support #4130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tommaso-moro
wants to merge
25
commits into
google:master
Choose a base branch
from
tommaso-moro:tommy/issue-dependencies-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
752e454
feat: Add Issue Dependencies API support
tommaso-moro 9aba995
chore: Regenerate accessors and iterators
tommaso-moro f57a237
chore: trigger CI
tommaso-moro 76cfab3
remove omitempty for required param
tommaso-moro 4550de5
pass by value instead of reference as param is required
tommaso-moro 13f260e
add missing fields to Issue struct
tommaso-moro 14b279b
Merge branch 'master' into tommy/issue-dependencies-support
tommaso-moro 6fd4bfd
use any instead of interface{}
tommaso-moro 171deba
Use int64 instead of *int64 for IssueID
tommaso-moro c5e05bf
Update number param to issueNumber for consistency, in github/issues_…
tommaso-moro 1d84d92
Update number param to issueNumber in github/issues_dependencies.go
tommaso-moro a3c6983
update number param to issueNumber
tommaso-moro 45fb09c
fix tests now that IssueID is of type int64
tommaso-moro 1e86822
update number param to issueNumber
tommaso-moro 0000b64
Use int64 for issueNumber parameter
tommaso-moro d261d4f
clean up test
tommaso-moro f4e9158
Merge branch 'master' into tommy/issue-dependencies-support
tommaso-moro 394a89c
Merge branch 'master' into tommy/issue-dependencies-support
tommaso-moro 23de54e
fix types
tommaso-moro 8f1e865
use shorthand or types
tommaso-moro f4515f7
go generate
tommaso-moro f207870
go generate
tommaso-moro ed9d275
fix tests
tommaso-moro 7f3990f
Merge branch 'master' into tommy/issue-dependencies-support
tommaso-moro dfd8467
Merge branch 'master' into tommy/issue-dependencies-support
tommaso-moro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This map must be kept in sync with the struct definitions manually, not sure if fine for now but open to suggestions for a better approach!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you revert all the changes made to
gen-stringify-test.go, what exactly breaks?If it is simply the formatting in a unit test, then I would say that I would rather update those broken unit tests than to make a new map of special special cases in
gen-strigify-test.go.