fix: support implicit @MethodSource to UnusedMethod#5610
Merged
copybara-service[bot] merged 1 commit intomasterfrom Mar 18, 2026
Merged
fix: support implicit @MethodSource to UnusedMethod#5610copybara-service[bot] merged 1 commit intomasterfrom
@MethodSource to UnusedMethod#5610copybara-service[bot] merged 1 commit intomasterfrom
Conversation
Currently, `UnusedMethod` check does not recognize implicitly referenced JUnit `@MethodSource`, e.g. the ones which are derived from test method name when none are specified explicitly. This PR fixes this issue. Fixes #5289 Fixes #5210 COPYBARA_INTEGRATE_REVIEW=#5210 from JarvisCraft:junit-implicit-method-source 457c855 PiperOrigin-RevId: 885662324
copybara-service
bot
force-pushed
the
test_829314044
branch
from
18bfead to
0dbf04a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: support implicit
@MethodSourcetoUnusedMethodCurrently,
UnusedMethodcheck does not recognize implicitly referenced JUnit@MethodSource, e.g. the ones which are derived from test method name when none are specified explicitly. This PR fixes this issue.Fixes #5289
Fixes #5210
FUTURE_COPYBARA_INTEGRATE_REVIEW=#5210 from JarvisCraft:junit-implicit-method-source 457c855