Repository navigation
Resolve legacy test harness HTTP aliases - #5568
Merged
Merged
Conversation
Xeicker
changed the title
Xeicker
changed the title
Collaborator
|
What's the context for this PR? |
Collaborator
Author
@IvanBM18 Found some 404 errors on aluminum fuzzers that uncover this bug. Adding context in the description |
dylanjew
reviewed
Oct 30, 2026
dylanjew
left a comment
dylanjew
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! is there a bug for this?
And is there a way to run the test syncer job to verify it as well? If you change it to just log the error this is less critical.
dylanjew
reviewed
Oct 30, 2026
Collaborator
Author
The bug is in b/570581291 |
Xeicker
changed the title
Add static HTTP_ALIASES in http_server.py for legacy Gecko Mochitest, Blink, and WebKit test-server mounts, verify all alias target directories exist before zipping web_tests.zip in chrome_tests_syncer.py, strip URL queries/fragments before resolving local paths, and log 404 misses at INFO level.
Xeicker
force-pushed
the
fix-blackbox-http-aliases
branch
from
October 30, 2026 21:20
c5c3a60 to
5ddd386
Compare
dylanjew
approved these changes
Nov 2, 2026
dylanjew
left a comment
dylanjew
left a comment
Collaborator
There was a problem hiding this comment.
Approving because this only affects blackbox and tests-syncer.
Could you update the description to match the changes?
Xeicker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
When blackbox browser fuzzing (e.g.
inferno_layout_test_fuzzer) serves corpus testcases fromweb_tests.zipoverBotHTTPServer(e.g. on Android emulators, whereFUZZ_DATAis served via HTTP), root-relative test-harness URLs (/tests/SimpleTest/...,/MochiKit/...,/js-test-resources/..., etc.) and WPT?pipe=query URLs fail with 404 (Could not find an absolute path for ...). Missing harness scripts (SimpleTest.js,js-test.js) abort testcase JS execution withReferenceError.Why not reuse Chromium's native web-test server setup: Chromium's
run_web_tests(apache_http.py/wptserve) runs separate servers/ports per suite, which collides with ClusterFuzz serving Blink, WPT, WebKit, Gecko, data bundles, and generated testcases from a singleBotHTTPServerport (where paths like/resources/overlap across suites), and with relying onhttp_server.get_absolute_testcase_file()in Python to package crash dependencies.Design notes:
web_tests.zipfor every other platform.WARNINGso missing or outdated mappings stay visible.Testing:
http_server_test.py,chrome_tests_syncer_test.py) andbutler.py lint.inferno_layout_test_fuzzeron an Android emulator blackbox job:413→0aliased/query 404s. Remaining 404s are genuinely absent assets (/favicon.ico,*.pydynamic handlers excluded fromweb_tests.zip).