Skip to content

No public description #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

No public description #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eval/public/containers/container_backed_map_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class CelValueEq {
} // namespace

// Map element access operator.
absl::optional<CelValue> CelMapBuilder::operator[](CelValue cel_key) const {
std::optional<CelValue> CelMapBuilder::operator[](CelValue cel_key) const {
auto item = values_map_.find(cel_key);
if (item == values_map_.end()) {
return absl::nullopt;
Expand Down
4 changes: 2 additions & 2 deletions eval/public/containers/internal_field_backed_map_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ absl::StatusOr<bool> FieldBackedMapImpl::Has(const CelValue& key) const {
return LookupMapValue(key, &value_ref);
}

absl::optional<CelValue> FieldBackedMapImpl::operator[](CelValue key) const {
std::optional<CelValue> FieldBackedMapImpl::operator[](CelValue key) const {
// Fast implementation which uses a friend method to do a hash-based key
// lookup.
MapValueConstRef value_ref;
Expand Down Expand Up @@ -236,7 +236,7 @@ absl::StatusOr<bool> FieldBackedMapImpl::LegacyHasMapValue(
return true;
}

absl::optional<CelValue> FieldBackedMapImpl::LegacyLookupMapValue(
std::optional<CelValue> FieldBackedMapImpl::LegacyLookupMapValue(
const CelValue& key) const {
// Ensure that the key matches the key type.
if (!MatchesMapKeyType(key_desc_, key)) {
Expand Down