Replace e2e cvd runner scripts with shared go library#2170
Merged
jmacnak merged 1 commit intogoogle:mainfrom Mar 2, 2026
Merged
Replace e2e cvd runner scripts with shared go library#2170jmacnak merged 1 commit intogoogle:mainfrom
jmacnak merged 1 commit intogoogle:mainfrom
Conversation
jmacnak
force-pushed
the
kokoro-gpu
branch
7 times, most recently
from
e1a2040 to
58f7a47
Compare
jmacnak
changed the title
jmacnak
force-pushed
the
kokoro-gpu
branch
2 times, most recently
from
7ef93a2 to
cab0892
Compare
ser-io
approved these changes
Feb 24, 2026
jmacnak
force-pushed
the
kokoro-gpu
branch
5 times, most recently
from
5a435ca to
6208556
Compare
Databean
reviewed
Feb 24, 2026
jmacnak
force-pushed
the
kokoro-gpu
branch
8 times, most recently
from
9727291 to
c7d9c88
Compare
ser-io
requested changes
Feb 25, 2026
jmacnak
force-pushed
the
kokoro-gpu
branch
2 times, most recently
from
0d0ce92 to
9368e5e
Compare
ser-io
approved these changes
Feb 25, 2026
Databean
approved these changes
Feb 26, 2026
jmacnak
force-pushed
the
kokoro-gpu
branch
4 times, most recently
from
b786529 to
66a48ee
Compare
Databean
approved these changes
Feb 27, 2026
Member
|
Sorry for leaving so comments, I want to be clear that I appreciate replacing the bash scripts because these are a lot nicer to read and understand. |
jmacnak
force-pushed
the
kokoro-gpu
branch
2 times, most recently
from
5e98071 to
903da71
Compare
... to consolidate all of the duplicated logic and to make it
easier to introduce new tests without having to create a new
shell file + bazel rule type. This change tries to match the
style of the e2etests/orchestration directory.
Note: the CTS tests remain as separate build targets as I did not
find a straightforward way to dynamically produce tests based on
CTS args.
Bug: b/466404901
Test: cd e2etests
bazel test cvd/...
Databean
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to consolidate all of the duplicated logic and to make it easier to introduce new tests without having to create a new shell file + bazel rule type.
The main motivation for this was to avoid also having to download the
device-tests.zipin addition to CTS in order to run the graphics detector tests. With this PR, addinge2etests/cvd/graphics_detector_tests/main_test.gowas pretty minimal.Note: the CTS tests remain as separate build targets as I did not find a straightforward way to dynamically produce tests based on CTS args.
Bug: b/466404901
Test:
This is first real golang CL so please be brutal with the comments :P