Migrate sample apps to UIKit scene-based lifecycle#278
Open
w-goog wants to merge 12 commits into
Open
Conversation
Contributor
Author
|
Ok at last I've been able to test this on-device, and it works a treat :) |
mdmathias
approved these changes
Jul 23, 2026
| /*! @file SceneDelegate.h | ||
| @brief GTMAppAuth SDK iOS Example | ||
| @copyright | ||
| Copyright 2016 Google Inc. |
Collaborator
There was a problem hiding this comment.
Update year. Please also confirm that this is the latest version of these details.
| /*! @file SceneDelegate.m | ||
| @brief GTMAppAuth SDK iOS Example | ||
| @copyright | ||
| Copyright 2016 Google Inc. |
|
|
||
| @property(strong, nonatomic) UIWindow *window; | ||
|
|
||
| /*! @brief The authorization flow session which receives the return URL from \SFSafariViewController. |
Collaborator
There was a problem hiding this comment.
Is SFSafariViewController at play here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the interest of fixing #276, we'll need to bump the sample apps to iOS 15+. Doing so requires using the scene-based lifecycle. This PR adds a scene delegate, and moves "auth session in-progress" check to that delegate.