Open
Conversation
…-patch Now that posembs is a configurable parameter in VisionEncoder (merged in PR #11), we can simply pass posembs=model_config.positional_embedding.shape instead of monkey-patching vit.py source code at runtime. Changes: - Remove the entire ViT.setup() monkey-patch and source file string-replace hack - Pass posembs directly via VisionEncoder constructor
Collaborator
Author
|
I've force-pushed the correct commit (e2c7264) to the scenic_demo branch, replacing the accidental merge commit. The PR is now ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a unified Scenic (JAX/Flax) demo notebook supporting both TIPSv1 and TIPSv2 models.
Supersedes #10 with a cleaner implementation that leverages the configurable
posembsparameter from #11.Key Changes
Notebook (
scenic/notebooks/TIPS_Demo.ipynb)tips_model_config.py) handles V1 vs V2 positional embedding sizes automatically(32, 32)positional embeddings are passed cleanly via:Checkpoint Downloads
download_checkpoints.shscriptsModel Config (
tips_model_config.py)positional_embedding.shapeper model versionCo-authored-by: washingtonsk8