fix: return full path in getTaskPath() instead of bare filename

[Nithwin]

Summary

Fixes #2970

Problem

In signals_test.go, getTaskPath() uses os.Stat("./bin/task") and returns info.Name(). The FileInfo.Name() method only returns the base filename ("task"), not the path passed to os.Stat ("./bin/task").

This means exec.Command receives "task" (bare name) and resolves it via $PATH, silently running signal tests against a system-installed binary instead of the locally-built one.

Fix

Store the path in a constant and return it directly:

 func getTaskPath() (string, error) {
-    if info, err := os.Stat("./bin/task"); err == nil {
-        return info.Name(), nil
+    const localTaskBin = "./bin/task"
+    if _, err := os.Stat(localTaskBin); err == nil {
+        return localTaskBin, nil
     }

Testing

• The fix is in the test file itself (signals_test.go)
• Verified that os.FileInfo.Name() only returns the base filename per the Go standard library docs

[Nithwin]

@trulede Could you give me your review please.

[trulede]

I make a suggestion, but otherwise fine.

[trulede]

I suggest this, with associated changes:

var sleepit, _ = filepath.Abs("./bin/sleepit")
var localTaskBinary, _ = filepath.Abs("./bin/task")

...

func TestSignalSentToProcessGroup(t *testing.T) {
	task := localTaskBinary
	if task == "" {
		// Fallback to system task if local build doesn't exist
		var err error
		task, err = exec.LookPath("task")
		if err != nil {
			t.Fatal(err)
		}
	}
	// ... rest of test
}

[Nithwin]

Thanks for the suggestion! 👍

I've implemented your approach and it's much better.

[Nithwin]

FYI - Using "Squash and merge" when merging this PR would ensure the contribution shows up in the contributors list. Thanks!

[trulede]

Fix sleepit too, style matters.

[trulede]

Now you don't check if the path exists? So the following code is not hit. Right?

This style is better when possible:
if task, err = exec.LookPath("task"); err != nil {
t.Fatal(err)
}

[Nithwin]

@trulede Thanks for catching that! You were totally right the path wasn't being checked for existence, so the fallback was never hit.

I just pushed an update:

1. I used exec.LookPath for both task and sleepit so the style is consistent. If the local binaries don't exist, it now properly falls back to the system ones.
2. I also fixed a bug I found while testing: for range tc.sendSigs - 1 was causing the loop to run 0 times, so the tests weren't even sending the signals! I changed it to for range tc.sendSigs and the tests pass properly now.

Thanks again for the help!
Looking forward to learn more from you