Repository navigation
Fix investigation snapshots, retries, and screenshot uploads - #550
Merged
Merged
Conversation
MaggieAppleton
force-pushed
the
debug-investigation-mcp
branch
from
October 13, 2026 11:35
46287bd to
a2815b2
Compare
MaggieAppleton
force-pushed
the
debug-investigation-mcp
branch
from
October 13, 2026 12:06
a2815b2 to
07e0741
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual investigations could inherit an older investigation’s source commit, and screenshot requests had no upload tool. Failed attempts also left a local receipt that blocked Retry and hid the agent’s explanation behind
missing-result.New investigations now use the selected connector checkout. Retrying keeps that investigation’s original commit and creates a separate checkout for its new claim generation. Manual investigations can upload up to three screenshots of 1 MiB each through the existing authenticated image pipeline; HTTP and stdio agents receive the same run-scoped tools and worktree-bounded file helper. Missing-result failures include the agent’s final explanation.
Changed flow
Verification
bun run ci, and the connector build passed.46287bd5. Browser results: 14 design, 16 gallery, and 710 integration passes; 8 skips. One unrelated integration case (a phone opens its documents in a bottom sheet over an inert page) passed on its first retry; no final failures or runner errors.After deployment, reconnect from the intended up-to-date checkout and create a new investigation to use its commit. Retrying an older investigation intentionally preserves its old source.
Landing validation
Rebased onto the merged UI batch with unchanged implementation patches. Fresh local CI, workspace types, connector build, 27 route/service tests and 32 connector tests pass; one credential-dependent ACP case is skipped. Lane constraints and explicit changed-source lint pass. The prior broader suites remain documented above; full GitHub CI is running on the refreshed head.
Final landing: the full GitHub validation, browser suite, and both CLI checks passed before this patch-preserving restack. The shared 43-byte Linux bundle overrun is fixed by #553. Source patches are unchanged on main
1d5492f3; fresh local project checks, types, and lane audit pass. Admin rebase merge deliberately skips repeating the full CI run after this base-only update.