Improving code generation for specific agent folders and files - #50470
Merged
pelikhan merged 7 commits intoAug 5, 2026
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
August 5, 2026 04:03
View session
pelikhan
marked this pull request as ready for review
August 5, 2026 04:04
Collaborator
|
@copilot .github always needs to be in the bundle |
Contributor
There was a problem hiding this comment.
Pull request overview
Scopes PR checkout manifest protection to the selected agent engine and declared ambient folders.
Changes:
- Resolves engine-specific manifest folders/files for save and restore steps.
- Narrows Copilot and Codex root manifests to
AGENTS.md. - Regenerates compiled workflows with scoped manifest lists.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/pr_test.go |
Tests scoped manifest resolution. |
pkg/workflow/copilot_engine.go |
Narrows Copilot root manifests. |
pkg/workflow/compiler_yaml_ai_execution.go |
Restores selected manifests. |
pkg/workflow/compiler_activation_steps.go |
Saves selected manifests. |
pkg/workflow/codex_engine.go |
Narrows Codex root manifests. |
.github/workflows/workflow-skill-extractor.lock.yml |
Regenerated manifest scope. |
.github/workflows/workflow-normalizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/workflow-health-manager.lock.yml |
Regenerated manifest scope. |
.github/workflows/workflow-generator.lock.yml |
Regenerated manifest scope. |
.github/workflows/weekly-issue-summary.lock.yml |
Regenerated manifest scope. |
.github/workflows/visual-regression-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/video-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/unbloat-docs.lock.yml |
Regenerated manifest scope. |
.github/workflows/uk-ai-operational-resilience.lock.yml |
Regenerated manifest scope. |
.github/workflows/typist.lock.yml |
Regenerated manifest scope. |
.github/workflows/test-quality-sentinel.lock.yml |
Regenerated manifest scope. |
.github/workflows/terminal-stylist.lock.yml |
Regenerated manifest scope. |
.github/workflows/super-linter.lock.yml |
Regenerated manifest scope. |
.github/workflows/sub-issue-closer.lock.yml |
Regenerated manifest scope. |
.github/workflows/step-name-alignment.lock.yml |
Regenerated manifest scope. |
.github/workflows/static-analysis-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/stale-repo-identifier.lock.yml |
Regenerated manifest scope. |
.github/workflows/stale-pr-cleanup.lock.yml |
Regenerated manifest scope. |
.github/workflows/squad-plan.lock.yml |
Regenerated manifest scope. |
.github/workflows/squad-game-planner.lock.yml |
Regenerated manifest scope. |
.github/workflows/spec-librarian.lock.yml |
Regenerated manifest scope. |
.github/workflows/spec-enforcer.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-workflow-call.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-workflow-call-with-inputs.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-test-tools.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-temporary-id.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-service-ports.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-pi.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-otel-backends.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-gemini.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-cursor.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-sub-agents.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-small.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-sdk.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-mai.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-auto.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-copilot-arm.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-codex.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-claude.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-ci.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-checkout-pr-dispatch.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-call-workflow.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-agent-scoped-approved.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-agent-public-none.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-agent-public-approved.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-agent-all-none.lock.yml |
Regenerated manifest scope. |
.github/workflows/smoke-agent-all-merged.lock.yml |
Regenerated manifest scope. |
.github/workflows/skillet.lock.yml |
Regenerated manifest scope. |
.github/workflows/sighthound-security-scan.lock.yml |
Regenerated manifest scope. |
.github/workflows/sergo.lock.yml |
Regenerated manifest scope. |
.github/workflows/semantic-function-refactor.lock.yml |
Regenerated manifest scope. |
.github/workflows/security-review.lock.yml |
Regenerated manifest scope. |
.github/workflows/security-compliance.lock.yml |
Regenerated manifest scope. |
.github/workflows/scout.lock.yml |
Regenerated manifest scope. |
.github/workflows/schema-consistency-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/safe-output-health.lock.yml |
Regenerated manifest scope. |
.github/workflows/ruflo-backed-task.lock.yml |
Regenerated manifest scope. |
.github/workflows/research.lock.yml |
Regenerated manifest scope. |
.github/workflows/repository-quality-improver.lock.yml |
Regenerated manifest scope. |
.github/workflows/repo-tree-map.lock.yml |
Regenerated manifest scope. |
.github/workflows/repo-audit-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/release.lock.yml |
Regenerated manifest scope. |
.github/workflows/refactoring-cadence.lock.yml |
Regenerated manifest scope. |
.github/workflows/python-data-charts.lock.yml |
Regenerated manifest scope. |
.github/workflows/prompt-clustering-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/pr-triage-agent.lock.yml |
Regenerated manifest scope. |
.github/workflows/pr-sous-chef.lock.yml |
Regenerated manifest scope. |
.github/workflows/pr-nitpick-reviewer.lock.yml |
Regenerated manifest scope. |
.github/workflows/pr-description-caveman.lock.yml |
Regenerated manifest scope. |
.github/workflows/pr-code-quality-reviewer.lock.yml |
Regenerated manifest scope. |
.github/workflows/portfolio-analyst.lock.yml |
Regenerated manifest scope. |
.github/workflows/poem-bot.lock.yml |
Regenerated manifest scope. |
.github/workflows/plan.lock.yml |
Regenerated manifest scope. |
.github/workflows/pdf-summary.lock.yml |
Regenerated manifest scope. |
.github/workflows/outcome-collector.lock.yml |
Regenerated manifest scope. |
.github/workflows/org-health-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/objective-impact-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/notion-issue-summary.lock.yml |
Regenerated manifest scope. |
.github/workflows/metrics-collector.lock.yml |
Regenerated manifest scope. |
.github/workflows/mcp-inspector.lock.yml |
Regenerated manifest scope. |
.github/workflows/mattpocock-skills-reviewer.lock.yml |
Regenerated manifest scope. |
.github/workflows/lockfile-stats.lock.yml |
Regenerated manifest scope. |
.github/workflows/lint-monster.lock.yml |
Regenerated manifest scope. |
.github/workflows/issue-triage-agent.lock.yml |
Regenerated manifest scope. |
.github/workflows/issue-monster.lock.yml |
Regenerated manifest scope. |
.github/workflows/issue-arborist.lock.yml |
Regenerated manifest scope. |
.github/workflows/instructions-janitor.lock.yml |
Regenerated manifest scope. |
.github/workflows/impeccable-skills-reviewer.lock.yml |
Regenerated manifest scope. |
.github/workflows/hourly-ci-cleaner.lock.yml |
Regenerated manifest scope. |
.github/workflows/hippo-embed.lock.yml |
Regenerated manifest scope. |
.github/workflows/grumpy-reviewer.lock.yml |
Regenerated manifest scope. |
.github/workflows/gpclean.lock.yml |
Regenerated manifest scope. |
.github/workflows/go-pattern-detector.lock.yml |
Regenerated manifest scope. |
.github/workflows/go-logger.lock.yml |
Regenerated manifest scope. |
.github/workflows/go-fan.lock.yml |
Regenerated manifest scope. |
.github/workflows/github-remote-mcp-auth-test.lock.yml |
Regenerated manifest scope. |
.github/workflows/github-mcp-tools-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/firewall.lock.yml |
Regenerated manifest scope. |
.github/workflows/firewall-escape.lock.yml |
Regenerated manifest scope. |
.github/workflows/example-workflow-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/example-permissions-warning.lock.yml |
Regenerated manifest scope. |
.github/workflows/example-failure-category-filter.lock.yml |
Regenerated manifest scope. |
.github/workflows/eslint-refiner.lock.yml |
Regenerated manifest scope. |
.github/workflows/eslint-monster.lock.yml |
Regenerated manifest scope. |
.github/workflows/duplicate-code-detector.lock.yml |
Regenerated manifest scope. |
.github/workflows/draft-pr-cleanup.lock.yml |
Regenerated manifest scope. |
.github/workflows/docs-noob-tester.lock.yml |
Regenerated manifest scope. |
.github/workflows/discussion-task-miner.lock.yml |
Regenerated manifest scope. |
.github/workflows/dev.lock.yml |
Regenerated manifest scope. |
.github/workflows/dev-hawk.lock.yml |
Regenerated manifest scope. |
.github/workflows/detection-analysis-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/designer-drift-audit.lock.yml |
Regenerated manifest scope. |
.github/workflows/design-decision-gate.lock.yml |
Regenerated manifest scope. |
.github/workflows/deployment-incident-monitor.lock.yml |
Regenerated manifest scope. |
.github/workflows/dependabot-go-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/delight.lock.yml |
Regenerated manifest scope. |
.github/workflows/deepsec-security-scan.lock.yml |
Regenerated manifest scope. |
.github/workflows/deep-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/dataflow-pr-discussion-dataset.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-windows-terminal-integration-builder.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-token-consumption-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-team-status.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-syntax-error-quality.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-squid-image-scan.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-spending-forecast.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-spdd-spec-planner.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-skill-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-sentrux-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-semgrep-scan.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-security-red-team.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-security-observability.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-secrets-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-safe-output-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-repo-chronicle.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-reliability-review.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-regulatory.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-performance-summary.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-observability-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-news.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-model-resolution.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-model-inventory.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-mcp-concurrency-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-max-ai-credits-test.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-malicious-code-scan.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-issues-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-hippo-learn.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-graft-intelligence.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-geo-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-function-namer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-formal-spec-verifier.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-firewall-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-file-diet.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-fact.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-experiment-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-evals-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-doc-updater.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-doc-healer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-credit-limit-test.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-compiler-quality.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-code-metrics.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-cli-tools-tester.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-cli-performance.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-choice-test.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-cache-strategy-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-byok-ollama-test.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-assign-issue-to-user.lock.yml |
Regenerated manifest scope. |
.github/workflows/daily-ambient-context-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-session-insights.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-pr-prompt-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-pr-nlp-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-pr-merged-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-opt.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-cli-deep-research.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-centralization-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-centralization-drilldown.lock.yml |
Regenerated manifest scope. |
.github/workflows/copilot-agent-analysis.lock.yml |
Regenerated manifest scope. |
.github/workflows/contribution-check.lock.yml |
Regenerated manifest scope. |
.github/workflows/constraint-solving-potd.lock.yml |
Regenerated manifest scope. |
.github/workflows/commit-changes-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/cloclo.lock.yml |
Regenerated manifest scope. |
.github/workflows/cli-version-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/cli-consistency-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/ci-doctor.lock.yml |
Regenerated manifest scope. |
.github/workflows/chaos-pr-bundle-fuzzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/breaking-change-checker.lock.yml |
Regenerated manifest scope. |
.github/workflows/bot-detection.lock.yml |
Regenerated manifest scope. |
.github/workflows/blog-auditor.lock.yml |
Regenerated manifest scope. |
.github/workflows/aw-failure-investigator.lock.yml |
Regenerated manifest scope. |
.github/workflows/avenger.lock.yml |
Regenerated manifest scope. |
.github/workflows/auto-triage-issues.lock.yml |
Regenerated manifest scope. |
.github/workflows/audit-workflows.lock.yml |
Regenerated manifest scope. |
.github/workflows/artifacts-summary.lock.yml |
Regenerated manifest scope. |
.github/workflows/architecture-guardian.lock.yml |
Regenerated manifest scope. |
.github/workflows/archie.lock.yml |
Regenerated manifest scope. |
.github/workflows/approach-validator.lock.yml |
Regenerated manifest scope. |
.github/workflows/api-consumption-report.lock.yml |
Regenerated manifest scope. |
.github/workflows/ai-moderator.lock.yml |
Regenerated manifest scope. |
.github/workflows/agentic-token-trend-audit.lock.yml |
Regenerated manifest scope. |
.github/workflows/agentic-token-optimizer.lock.yml |
Regenerated manifest scope. |
.github/workflows/agentic-token-audit.lock.yml |
Regenerated manifest scope. |
.github/workflows/agent-persona-explorer.lock.yml |
Regenerated manifest scope. |
.github/workflows/agent-performance-analyzer.lock.yml |
Regenerated manifest scope. |
.github/workflows/ace-editor.lock.yml |
Regenerated manifest scope. |
.github/workflows/ab-testing-advisor.lock.yml |
Regenerated manifest scope. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 282/282 changed files
- Comments generated: 1
- Review effort level: Balanced
| // placed in .github/skills/ by pre-agent-steps are not clobbered by this restore. | ||
| if ShouldGeneratePRCheckoutStep(data) { | ||
| registry := c.engineRegistry | ||
| folders, files := resolveAgentManifestPaths(c.engineRegistry, data) |
Contributor
Author
There was a problem hiding this comment.
Fixed in 7473228: resolveAgentManifestPaths now falls back to GetEngineByPrefix when the exact GetEngine lookup fails, so aliases like codex-experimental resolve to .codex/AGENTS.md correctly. Added TestResolveAgentManifestPaths/resolves_engine_via_prefix_alias as the regression case.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
August 5, 2026 04:19
Collaborator
|
@copilot resolve the merge conflicts on this branch. |
…eneration-gh-aw-agent-folders-files # Conflicts: # .github/workflows/smoke-kiro.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Merged main and resolved the conflict in |
Collaborator
|
@copilot Please take another pass on this PR.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Contributor
Author
Fixed |
Collaborator
|
@copilot fix wasm golden |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Fixed in |
Contributor
|
Thanks for working on improving code generation! 🚀 However, this PR doesn't follow the contribution process outlined in our CONTRIBUTING.md. Our project uses agentic development by the core team, and traditional pull requests are not enabled for non-Core team members. Here's what should have happened instead:
The contributing guidelines are explicit:
Next steps:
If you're part of the core team or have special authorization, please let us know and we can discuss this further! Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "patchdiff.githubusercontent.com"See Network Configuration for more information.
|
Collaborator
|
@copilot Please take another pass on this PR.
|
Contributor
Author
The contribution-check comment is a false positive here: this PR was opened by the Copilot coding agent at the request of @pelikhan (a core team member), which is the sanctioned agentic workflow described in CONTRIBUTING.md, not an unauthorized direct PR from an external contributor. No follow-up action is needed on the contribution-policy front. All prior feedback ( |
Collaborator
|
@copilot Please take another pass on this PR.
|
Contributor
🏷️ PR Triage
RationaleLarge cross-cutting change (1373+/1301- across 290 files, mostly regenerated
|
Collaborator
|
@copilot Please take another pass on this PR.
|
Collaborator
|
@copilot Please take another pass on this PR.
|
Collaborator
|
@copilot Please take another pass on this PR.
|
pelikhan
deleted the
copilot/improve-codegeneration-gh-aw-agent-folders-files
branch
August 5, 2026 13:04
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent
Run: https://github.com/github/gh-aw/actions/runs/30990520821
Run: https://github.com/github/gh-aw/actions/runs/31005207589