🧹 Remove old package functionality in workflow addition

[dsyme]

Summary

• Removed legacy package workflow handling code in the add_command.go file
• Simplified workflow resolution and addition logic
• Removed unused package discovery and installation methods

Changes

• Deleted code related to repo-only workflow listing
• Simplified workflow resolution process
• Removed wildcard handling for remote repositories
• Enhanced local wildcard workflow expansion
• Removed fallback path resolution for workflow discovery

Motivation

The changes streamline the workflow addition process, removing outdated functionality and making the code more focused and maintainable.

[Copilot]

Pull request overview

This PR removes the legacy “package install + local cache” workflow-addition path and shifts workflow resolution to fetch remote workflows directly from GitHub, while adding/expanding support for local workflow specs and local wildcard expansion.

Changes:

• Remove repository “package” install/list/discovery code paths and related tests.
• Resolve remote workflows by fetching content from GitHub (no cloning) and pass pre-fetched content through the add pipeline.
• Add local-path detection helper and local wildcard expansion logic; update tests accordingly.

Reviewed changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pkg/workflow/compiler_activation_jobs.go	Pure formatting/gofmt adjustments in activation sparse checkout helper.
pkg/parser/remote_fetch.go	Adds exported wrappers for internal GitHub fetch/ref-resolution helpers.
pkg/cli/trial_repository.go	Switches trial-mode remote workflow install from “install package + add” to direct fetch + write.
pkg/cli/spec.go	Adds isLocalWorkflowPath and expands local-path detection in parsing/stringification.
pkg/cli/packages.go	Removes package install/list/discovery functionality; refactors include dependency collection naming/struct fields.
pkg/cli/packages_test.go	Updates tests to use renamed local include dependency collector.
pkg/cli/packages_fallback_test.go	Deletes tests for removed fallback path/package workflow resolution behavior.
pkg/cli/local_workflow_trial_test.go	Updates local path assertions to use isLocalWorkflowPath.
pkg/cli/local_workflow_integration_test.go	Updates expectations to new WorkflowSourceInfo shape (IsLocal).
pkg/cli/commands_utils_test.go	Removes tests tied to deleted copyMarkdownFiles helper and related import.
pkg/cli/commands_test.go	Removes tests for deleted InstallPackage behavior.
pkg/cli/add_workflow_resolution.go	Removes “install packages then read from disk” resolution; fetches remote content directly; adds local-only wildcard expansion.
pkg/cli/add_workflow_repository.go	Deletes repo-only “list workflows” interactive/table UX path.
pkg/cli/add_workflow_pr.go	PR-creation path now operates on pre-resolved workflows.
pkg/cli/add_workflow_not_found_test.go	Deletes tests for removed “display available workflows” behavior.
pkg/cli/add_wildcard_test.go	Updates wildcard tests for local wildcard expansion and removes package discovery tests.
pkg/cli/add_repo_only_test.go	Removes tests that depended on deleted package workflow listing / repo-only handling.
pkg/cli/add_interactive_workflow_test.go	Tweaks expectations around getWorkflowStatuses return values in test environment.
pkg/cli/add_interactive_orchestrator.go	Removes outdated comment referencing removed add path.
pkg/cli/add_gitattributes_test.go	Updates tests to call new addWorkflows([]*ResolvedWorkflow, ...) path.
pkg/cli/add_command_test.go	Updates expectation: repo-only specs now error with format guidance.
pkg/cli/add_command_table_test.go	Deletes table-display tests for removed workflow listing UX.
pkg/cli/add_command.go	Removes repo-only listing + package install flow; “add” now resolves to pre-fetched workflows and adds them; documents local specs and local wildcards.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 6 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.