unified: Don't try to build an extractor binary on windows - #22335
Open
asgerf wants to merge 2 commits into
Open
unified: Don't try to build an extractor binary on windows#22335asgerf wants to merge 2 commits into
asgerf wants to merge 2 commits into
Conversation
This mirrors the approach taken by the original Swift extractor
asgerf
force-pushed
the
unified/no-windows
branch
from
August 14, 2026 11:31
936e275 to
81f626a
Compare
asgerf
marked this pull request as ready for review
August 14, 2026 11:32
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Windows-compatible fallback executable so packaging avoids building the unsupported unified extractor.
Changes:
- Adds a fallback Rust executable that reports unsupported extraction.
- Selects the real extractor on POSIX and the fallback on Windows.
Show a summary per file
| File | Description |
|---|---|
unified/BUILD.bazel |
Selects the extractor by OS. |
unified/extractor-unsupported-os/BUILD.bazel |
Defines the fallback binary. |
unified/extractor-unsupported-os/Cargo.toml |
Adds fallback crate metadata. |
unified/extractor-unsupported-os/src/main.rs |
Implements the failure diagnostic. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
jketema
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to unblock DCA support while we don't have build support on Windows yet.