Shared CFG: allow init stmts for IfStmt#21914
Open
owen-mc wants to merge 2 commits into
Open
Conversation
Contributor
Author
Rerun has been triggered: 2 restarted 🚀 |
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the shared CFG library’s AST signature and successor construction to support languages with if statements that may include an initializer statement (evaluated before the condition), aligning shared CFG behavior with such frontends.
Changes:
- Added a new
AstSighookgetIfInit(IfStmt)(defaulting tonone()). - Updated
Make0successor logic forIfStmtto route control flow through the init (when present) before evaluating the condition.
Show a summary per file
| File | Description |
|---|---|
| shared/controlflow/codeql/controlflow/ControlFlowGraph.qll | Adds an IfStmt init hook and updates shared CFG successor relationships to incorporate init-before-condition flow. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
hvitved
requested changes
Jun 2, 2026
Co-authored-by: Tom Hvitved <hvitved@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spun out from #21614.