Override vulnerable Undici transitives - #113
Merged
Merged
Conversation
Co-authored-by: GitHub Copilot <copilot@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Remediates vulnerable transitive Undici 5.x dependencies without altering the production Undici version.
Changes:
- Adds package-specific overrides to Undici 6.28.0.
- Removes obsolete Undici 5.29.0 and Busboy lockfile entries.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds scoped Undici overrides. |
package-lock.json |
Removes superseded transitive packages. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
johan-j
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelsAIModeratorAction / Security: #198168, #225845, and #230188. The findings are assigned to@sgoedeckefor this remediation.@actions/github@6.0.1and@actions/github@7.0.0, the two packages that directly request vulnerable Undici 5.x copies under@github/local-action@7.0.1.undici@6.28.0unchanged and avoid a global Undici override.Dependency graph
Before:
@github/local-action@7.0.1 > @actions/artifact@5.0.3 > @actions/github@6.0.1 > undici@5.29.0@github/local-action@7.0.1 > @actions/artifact@5.0.3 > @actions/github@6.0.1 > @actions/http-client@2.2.3 > undici@5.29.0(deduped)@github/local-action@7.0.1 > @actions/github@7.0.0 > undici@5.29.0undici@6.28.0After:
undici@6.28.0.undici@5.29.0lockfile nodes are removed.@fastify/busboy@2.1.1lockfile node is removed.undici@6.28.0.The initially considered
@github/local-action@7.0.1ancestor override covered only one physical npm subtree because@actions/artifactis hoisted. Exact overrides on the two dependency owners cover both lineages without broadening the production dependency graph.Validation
npm ciwith the repository-pinned Node.js20.9.0npm run format:checknpm run lintnpm run ci-test— 3 suites, 22 tests passednpm run bundle;dist/remains unchangednpm ls undici @fastify/busboy @actions/github --all— all Undici paths resolve to6.28.0; Busboy is absentnpm audit --package-lock-only— Undici finding removed; total pre-existing dev findings reduced from 9 to 4npm audit --package-lock-only --omit=dev— 0 vulnerabilitiesCheck Licensesand enterprise license compliance checks passed in PR CIdist/checks passedVulnerability scanner re-evaluation and robot-managed finding closure are automatic after merge; no findings should be manually closed.