[GHSA-p773-8mf4-rjm5] @farmfe/core is Missing Origin Validation in WebSocket#6931
Open
cai0duque wants to merge 1 commit intocai0duque/advisory-improvement-6931from
Open
[GHSA-p773-8mf4-rjm5] @farmfe/core is Missing Origin Validation in WebSocket#6931cai0duque wants to merge 1 commit intocai0duque/advisory-improvement-6931from
cai0duque wants to merge 1 commit intocai0duque/advisory-improvement-6931from
Conversation
github-actions
bot
changed the base branch from
main
to
cai0duque/advisory-improvement-6931
There was a problem hiding this comment.
Pull request overview
This PR updates a security advisory (GHSA-p773-8mf4-rjm5) for the @farmfe/core npm package to improve its accuracy and clarity. The advisory addresses a Cross-Site WebSocket Hijacking (CSWSH) vulnerability due to missing origin validation in the WebSocket server used for hot module reloading.
Changes:
- Upgraded CVSS scoring from v3.1 to v4.0, reflecting the "Passive" user interaction required for the attack
- Increased severity from MODERATE to HIGH based on the updated CVSS v4.0 metrics
- Enhanced the vulnerability description to use industry-standard CSWSH terminology and provide clearer attack scenario details
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Updated severity metrics to CVSS 4.0 to more accurately reflect the "Passive" User Interaction required for Cross-Site WebSocket Hijacking (CSWSH). Refined the description to explicitly use the industry-standard term CSWSH and clarify the attack scenario.