Handle permissions for follower correctly#126
Draft
yaananth wants to merge 4 commits intogithub:mainfrom
Draft
Conversation
e1839bd to
b6d22fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We noticed failure at https://github.com/github/warehouse-config/actions/runs/19678778678/job/56367139412
Summary
Before
.show follower database My-DB (unquoted) — fails on special names..set database <db> admins/viewers (…)— rejected on followers; clearing roles emitted (none).After
.show follower database ['My-DB']..alter follower database <db> principals-modification-kind = <kind>then:.drop follower database <db> admins|viewers ("…").add follower database <db> admins|viewers ("…") ['leader']Works on read-only followers and correctly clears or sets principals.