Remove obsolete references to screenshot snapshots#2135
Open
dscho wants to merge 1 commit intogit:gh-pagesfrom
Open
Remove obsolete references to screenshot snapshots#2135dscho wants to merge 1 commit intogit:gh-pagesfrom
dscho wants to merge 1 commit intogit:gh-pagesfrom
Conversation
In e3c066e ("test: verify dark/light mode via normalized relative luminance"), the dark mode test was rewritten to use an average-brightness approach instead of comparing against reference screenshots. Follow-up commit f3d3240 ("test: remove screenshot snapshots for dark/light mode tests") removed the tracked Linux snapshot images, but left behind the `.gitignore` entries that suppressed the non-Linux (macOS and Windows) snapshots, as well as the README note explaining that the first test run on those platforms would "fail" while generating the baseline screenshots. Since `toHaveScreenshot` is no longer used anywhere in the test suite, clean up these leftovers: remove the two `.gitignore` patterns for `*-darwin.png` and `*-win32.png` in the snapshots directory, and remove the now-inaccurate README paragraph about first-run screenshot failures on non-Linux platforms. Assisted-by: Claude Opus 4.6 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
In e3c066e ("test: verify dark/light mode via normalized relative luminance"), the dark mode test was rewritten to use an average-brightness approach instead of comparing against reference screenshots. Follow-up commit f3d3240 ("test: remove screenshot snapshots for dark/light mode tests") removed the tracked Linux snapshot images, but left behind the
.gitignoreentries that suppressed the non-Linux (macOS and Windows) snapshots, as well as the README note explaining that the first test run on those platforms would "fail" while generating the baseline screenshots.Since
toHaveScreenshotis no longer used anywhere in the test suite, clean up these leftovers: remove the two.gitignorepatterns for*-darwin.pngand*-win32.pngin the snapshots directory, and remove the now-inaccurate README paragraph about first-run screenshot failures on non-Linux platforms.