Skip to content

Updates to EAS build hooks #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alwx merged 1 commit into from
Mar 5, 2026
Merged

Updates to EAS build hooks #5773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/core/scripts/eas-build-hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,9 @@ const HOOK_CONFIGS = {
successMessage: 'SENTRY_EAS_BUILD_SUCCESS_MESSAGE',
captureSuccessfulBuilds: 'SENTRY_EAS_BUILD_CAPTURE_SUCCESS',
},
// When a user explicitly configures the on-success hook, they intend to
// capture successful builds, so default captureSuccessfulBuilds to true.
defaults: { captureSuccessfulBuilds: true },
method: 'captureEASBuildSuccess',
},
};
Expand All @@ -169,11 +172,17 @@ async function runEASBuildHook(hookName) {
loadEnv();

const hooks = loadHooksModule();
const options = parseBaseOptions();
const options = {
...parseBaseOptions(),
...config.defaults,
};

for (const [optionKey, envKey] of Object.entries(config.envKeys)) {
if (optionKey === 'captureSuccessfulBuilds') {
options[optionKey] = process.env[envKey] === 'true';
// Only override the default when the env var is explicitly set
if (process.env[envKey] !== undefined) {
options[optionKey] = process.env[envKey] === 'true';
}
} else if (process.env[envKey] !== undefined) {
options[optionKey] = process.env[envKey];
}
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/js/tools/easBuildHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import type { DsnComponents } from '@sentry/core';
import { dsnToString, makeDsn, uuid4 } from '@sentry/core';
import { SDK_VERSION } from '../version';

const SENTRY_DSN_ENV = 'SENTRY_DSN';
const EAS_BUILD_ENV = 'EAS_BUILD';
Expand Down Expand Up @@ -179,7 +180,7 @@ function createBaseEvent(
release: getReleaseFromEASEnv(env),
tags: { ...createEASBuildTags(env), ...customTags },
contexts: { eas_build: createEASBuildContext(env), runtime: { name: 'node', version: process.version } },
sdk: { name: 'sentry.javascript.react-native.eas-build-hooks', version: '1.0.0' },
sdk: { name: 'sentry.javascript.react-native.eas-build-hooks', version: SDK_VERSION },
};
}

Expand Down
Loading