fix(openai): Only finish relevant spans in Responses patches#6191
Merged
alexander-alderman-webb merged 9 commits intomasterfrom May 5, 2026
Merged
Conversation
alexander-alderman-webb
changed the title
Contributor
Codecov Results 📊✅ 2187 passed | ⏭️ 154 skipped | Total: 2341 | Pass Rate: 93.42% | Execution Time: 5m 0s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 12661 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sentrivana
approved these changes
May 4, 2026
…ebb/openai/remove-get-current-span-responses
Base automatically changed from
webb/openai/remove-get-current-span-completions
to
master
May 5, 2026 14:45
alexander-alderman-webb
deleted the
webb/openai/remove-get-current-span-responses
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenAI Responses spans are only created in
_new_sync_responses_create()and_new_async_responses_create().Exit spans in these functions when the openai library function raises an exception.
Resolves an edge case where
_new_sync_responses_create()or_new_async_responses_create()exits early and does not create a span andget_current_span()therefore returns a non-openai span.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)