fix(metrics,logs): Don't attach span_id if no active span#6162
Merged
sentrivana merged 10 commits intomasterfrom Apr 30, 2026
Merged
fix(metrics,logs): Don't attach span_id if no active span#6162sentrivana merged 10 commits intomasterfrom
span_id if no active span#6162sentrivana merged 10 commits intomasterfrom
Conversation
span_id if no active span
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.01s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 14873 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
ericapisani
approved these changes
Apr 28, 2026
Member
ericapisani
left a comment
There was a problem hiding this comment.
Other than the notes from Cursor, this LGTM. Approving so as not to block
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a98293d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Per the log/metrics spec, we shouldn't attach a span ID unless there's an active span. In the current implementation, due to how the propagation context works, we'd synthesize a span ID in this case.
Circumvent that code path by directly checking for an active span.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)