test(stdlib): Pin timestamps in add_http_request_source() patch#6160
Merged
alexander-alderman-webb merged 5 commits intomasterfrom Apr 29, 2026
Merged
test(stdlib): Pin timestamps in add_http_request_source() patch#6160alexander-alderman-webb merged 5 commits intomasterfrom
add_http_request_source() patch#6160alexander-alderman-webb merged 5 commits intomasterfrom
Conversation
alexander-alderman-webb
changed the title
getresponse() instead of putrequest()
Contributor
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 10.00s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14868 uncovered lines. Generated by Codecov Action |
alexander-alderman-webb
changed the title
getresponse() instead of putrequest()add_http_request_source()
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 22b2886. Configure here.
alexander-alderman-webb
changed the title
add_http_request_source()add_http_request_source()
sentrivana
approved these changes
Apr 29, 2026
alexander-alderman-webb
changed the title
add_http_request_source()add_http_request_source() patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overwrite span timestamps in a patch of
add_http_request_sourceinstead of aHTTPConnectionsubclass.Enables creating an analogous version with the streaming lifecycle in #6154, as
StreamedSpan._end()exits early when_timestampis already set.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)