Skip to content

ref(grpc): Mirror sync interceptor #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 2 commits into from
Apr 28, 2026
Merged

ref(grpc): Mirror sync interceptor #6158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c631eb
tentantive fix
sentrivana Apr 28, 2026
1a6b30c
remove test
sentrivana Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sentry_sdk/integrations/grpc/aio/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def __init__(
self: "ServerInterceptor",
find_name: "Callable[[ServicerContext], str] | None" = None,
) -> None:
self._find_method_name = find_name or self._find_name
self._custom_find_name = find_name

super().__init__()

Expand All @@ -34,17 +34,21 @@ async def intercept_service(
continuation: "Callable[[HandlerCallDetails], Awaitable[RpcMethodHandler]]",
handler_call_details: "HandlerCallDetails",
) -> "Optional[Awaitable[RpcMethodHandler]]":
self._handler_call_details = handler_call_details
handler = await continuation(handler_call_details)
if handler is None:
return None

method_name = handler_call_details.method
custom_find_name = self._custom_find_name

if not handler.request_streaming and not handler.response_streaming:
handler_factory = grpc.unary_unary_rpc_method_handler

async def wrapped(request: "Any", context: "ServicerContext") -> "Any":
with sentry_sdk.isolation_scope():
name = self._find_method_name(context)
name = (
custom_find_name(context) if custom_find_name else method_name
)
if not name:
return await handler(request, context)

Expand Down Expand Up @@ -96,6 +100,3 @@ async def wrapped(request: "Any", context: "ServicerContext") -> "Any": # type:
request_deserializer=handler.request_deserializer,
response_serializer=handler.response_serializer,
)

def _find_name(self, context: "ServicerContext") -> str:
return self._handler_call_details.method
Loading