Repository navigation
Conversation
`@apm-js-collab/code-transformer-bundler-plugins` 0.7.4 gave the combined input source map to the code transformer once `outputOptions` had run, and Rolldown calls `outputOptions` before the transforms. The transformer then added a second source `<package>/<file>` (for example `ioredis/built/Redis.js`) without `sourcesContent`. That file does not exist, so source map flattening (for example in `@sentry/sveltekit`) failed for the whole chunk. 0.7.5 gives the real file path to the transformer (code-transformer 0.19.0) and no longer gives it the input map, so the map of an instrumented module only names its file in `node_modules`. This also fixes the source name of instrumented modules in webpack. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 609a0cc (PR test merge using develop at 10056d4) Against: 1177c46 (develop) · base run #63809
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 59 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(fwiw: CI might fail now, as locally I excluded the package via
minimumReleaseAgeExcludeto test it locally - will rerun the job ones it is done)closes #25329
closes JS-3928
Description
This bumps
@apm-js-collab/code-transformer-bundler-pluginsto 0.7.5, which has the upstream fix (apm-js-collab/code-transformer-bundler-plugins#50, nodejs/orchestrion-js#104). The source map of an instrumented module now names its real file innode_modules, withsourcesContent. Before, Vite 8 and webpack builds had a<package>/<file>source that does not exist (for exampleioredis/built/Redis.js), and source map flattening in@sentry/sveltekitfailed for that chunk.Type decisions
code-transformer 0.19.0 also allows a function in the
transformfield of an instrumentation. I castserializeInstrumentationsto our vendored types, so the publictransformtype staysstring. The alternative is to also allow a function in the vendored type.