feat(nuxt)!: Emit low cardinality db span names - #23605
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
With span streaming, `db0` query spans are named after their `db.query.summary` (`SELECT users`) instead of the full SQL statement, and report that summary as a new `db.query.summary` attribute. The statement is sanitized before it is summarized, so a string literal containing `from`/`join` cannot leak a value into the name. db0 reports no db system, so a statement that cannot be summarized falls back to `db.namespace` and then to the static `Database operation`. `traceLifecycle: 'static'` keeps the existing names. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8524d24. Configure here.
| name: streamedName ?? query, | ||
| attributes: { | ||
| 'db.query.text': query, | ||
| 'db.query.summary': querySummary, |
There was a problem hiding this comment.
Missing tests for new behavior
Medium Severity
This feat PR changes streamed db.query span names and always sets db.query.summary, but the diff adds no integration or E2E coverage for that behavior. Existing Nuxt DB E2E suites stay on traceLifecycle: 'static' and never assert db.query.summary, so the new path is untested.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 8524d24. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
db0query spans are named afterdb.query.summarySELECT * FROM users WHERE id = ?becomesSELECT usersdb.namespace, then toDatabase operationdb.query.summaryattribute, set in both trace lifecyclestraceLifecycle: 'static'keeps the existing namesRefs #23523