feat(cloudflare)!: Emit low cardinality D1 db span names - #23604
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
With span streaming, D1 query spans are named after their `db.query.summary` (`SELECT users`) instead of the full SQL statement, and report that summary as a new `db.query.summary` attribute. The statement is sanitized before it is summarized, so a string literal containing `from`/`join` cannot leak a value into the name. D1 exposes no collection, namespace or server to pair the operation with, so a statement that cannot be summarized falls back to `db.system.name`. `batch` spans keep their name and get no summary, since their `db.query.text` is several statements joined together. `traceLifecycle: 'static'` keeps the existing names. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
db.query.summarySELECT * FROM users WHERE id = ?becomesSELECT usersdb.system.namedb.query.summaryattribute, set in both trace lifecyclesbatchspans keep their name; their text is many statementstraceLifecycle: 'static'keeps the existing namesRefs #23523