feat(server-utils)!: Emit low cardinality redis and mongodb span names - #23603
Draft
Lms24 wants to merge 1 commit into
Draft
feat(server-utils)!: Emit low cardinality redis and mongodb span names#23603Lms24 wants to merge 1 commit into
Lms24 wants to merge 1 commit into
Conversation
Neither driver reports a SQL statement, so there is no query summary to name
their spans after. With span streaming they use the next conventions template
they can fill instead: redis pairs the command with `{server.address}:{server.port}`
(it has no collection or namespace), mongodb pairs the operation with
`{db.collection.name}`. Both fall back to `{db.system.name}`.
This keeps the serialized redis command, which carries the key and its
arguments, out of the span name. It stays on `db.query.text`.
`traceLifecycle: 'static'` keeps the existing names.
Refs #23523
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 866f29c. Configure here.
| attributes: expect.objectContaining({ 'db.query.text': 'set test-key [1 other arguments]' }), | ||
| }), | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Missing streamed integration tests
Medium Severity
This feat PR only adds a unit test for the ioredis orchestrion path. Per the review rules, feat PRs need at least one integration or E2E test. The new low-cardinality naming for redis (startCommandSpan) and mongodb (startMongoSpan) also has no coverage, and there is no streamed suite like postgres-streamed. Flagged because it was mentioned in the rules file.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 866f29c. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neither driver has a SQL statement to summarize. With span streaming enabled:
{command} {server.address}:{server.port}set test-key [1 other arguments]becomesset localhost:6379{db.operation.name} {db.collection.name}, e.g.find usersdb.system.namedb.query.texttraceLifecycle: 'static'keeps the existing namesRefs #23523