feat(server-utils): Emit low cardinality mysql db span names - #23601
Open
Lms24 wants to merge 2 commits into
Open
feat(server-utils): Emit low cardinality mysql db span names#23601Lms24 wants to merge 2 commits into
Lms24 wants to merge 2 commits into
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'db', | ||
| [DB_SYSTEM_NAME]: DB_SYSTEM_NAME_VALUE_MYSQL, | ||
| [DB_QUERY_TEXT]: queryText, | ||
| [DB_QUERY_SUMMARY]: querySummary, |
There was a problem hiding this comment.
MySQL escapes leak into summaries
Medium Severity
Summaries are built after _INTERNAL_sanitizeSqlQuery, which only treats doubled quotes ('') as escaped string delimiters. mysql2's query channel inlines values with MySQL backslash escapes (\'), so a literal that contains a quote plus FROM/JOIN is only partially stripped and can still land in db.query.summary and the streamed span name.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit f7c6bc0. Configure here.
Member
Author
There was a problem hiding this comment.
might be an issue but a broader one than this change. I wanna look into this separately.
Contributor
size-limit report 📦
|
With span streaming, `mysql` and `mysql2` query spans are named after their `db.query.summary` (`SELECT users`) instead of the full SQL statement, and report that summary as a new `db.query.summary` attribute. Both mysql2 paths (the orchestrion channels below 3.20.0 and the native diagnostics channels from 3.20.0 on) are covered, so the name does not depend on the driver version. The statement is sanitized before it is summarized, so a string literal containing `from`/`join` cannot leak a value into the name. `traceLifecycle: 'static'` keeps the existing names. Refs #23523 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/feat-server-utils-low-card-db-span-names2
branch
from
August 26, 2026 12:53
f7c6bc0 to
58cd60c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 58cd60c. Configure here.
| const client = getClient(); | ||
| // The statement is sanitized before it is summarized, so that a string literal containing | ||
| // `from`/`join` can't leak a value into the summary. | ||
| const querySummary = sql ? _INTERNAL_getSqlQuerySummary(_INTERNAL_sanitizeSqlQuery(sql)) : undefined; |
There was a problem hiding this comment.
MySQL literals can leak into summaries
Medium Severity
_INTERNAL_sanitizeSqlQuery only strips single-quoted literals, but MySQL treats double-quoted values as strings unless ANSI_QUOTES is on, and also allows backslash escapes. A user value containing from or join can therefore survive sanitization and land in db.query.summary and streamed span names, which this change presents as low-cardinality and leak-free.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 58cd60c. Configure here.
Lms24
marked this pull request as ready for review
August 26, 2026 13:20
Lms24
requested review from
JPeer264 and
isaacs
and removed request for
a team
August 26, 2026 13:20
Lms24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With span streaming enabled:
mysqlandmysql2query spans are named afterdb.query.summarySELECT solution FROM mathsbecomesSELECT mathsdb.namespace, thendb.system.namedb.query.summaryattribute, set in both trace lifecyclesRefs #23523