ref(build): Switch TypeScript moduleResolution to bundler#21559
Open
logaretm wants to merge 1 commit into
Open
ref(build): Switch TypeScript moduleResolution to bundler#21559logaretm wants to merge 1 commit into
bundler#21559logaretm wants to merge 1 commit into
Conversation
Changes the shared base tsconfig from `moduleResolution: "node"` to `"bundler"` (supported since TS 5.0, no TypeScript upgrade required). `bundler` resolution respects package `exports` maps, so deep imports into non-exported subpaths no longer resolve. - Replace the deep `svelte/types/compiler*` type imports with `svelte/compiler` and a small set of vendored preprocessor types. - Inline `@sentry/angular`'s `tsconfig.ngc.json` so it no longer extends the shared base config — ng-packagr ships an older TypeScript that rejects `"moduleResolution": "bundler"` when parsing the extends chain. - Downgrade `bundler` back to `node` in the TS 3.8 compat scripts, since TS 3.8 predates the `bundler` option.
logaretm
requested review from
JPeer264,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes our module resolution strategy from
nodewhich is deprecated in next releases tobundlerwhich better reflects our own setup.Some changes were required for
svelteSDK because it imported non-exportable types, I opted to vendor them instead. Also one minor exception is introduced for TypeScript 3.8 because it does not supportbundlermodule resolution strategy.replaces #21520