ref(opentelemetry): Use @sentry/conventions#21495
Draft
mydea wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
mydea
requested review from
JPeer264,
andreiborza and
nicohrubec
and removed request for
a team
mydea
force-pushed
the
feat/use-sentry-conventions-opentelemetry
branch
from
ef58787 to
daea6f6
Compare
mydea
changed the base branch from
develop
to
feat/use-sentry-conventions-build-infra
mydea
force-pushed
the
feat/use-sentry-conventions-build-infra
branch
from
625467a to
2a83a9f
Compare
Member
|
Will review again once this is not a draft anymore. The changes as of now looks good, build is failing though. |
mydea
force-pushed
the
feat/use-sentry-conventions-opentelemetry
branch
from
daea6f6 to
ed4204f
Compare
mydea
changed the base branch from
feat/use-sentry-conventions-build-infra
to
develop
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed4204f. Configure here.
Source span/attribute keys from `@sentry/conventions` as a regular dependency (externalized at build time, resolved at runtime). No functional change. Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the repo's `node` moduleResolution type builds. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/use-sentry-conventions-opentelemetry
branch
from
ed4204f to
e79c20c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches
@sentry/opentelemetryto source span/attribute keys from@sentry/conventions, added as a regular runtimedependencyand externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.Also maps the
@sentry/conventions/attributessubpath inpackages/typescript/tsconfig.jsonfor the repo'snodemoduleResolution type builds.Part of splitting the larger
@sentry/conventionsmigration into per-package PRs.Ref: #20982