feat(bun): Add orchestrion bun build plugin#21410
Conversation
48fa3e3 to
0157d09
Compare
362c870 to
39be3da
Compare
size-limit report 📦
|
0157d09 to
25bfdaa
Compare
39be3da to
b34aa87
Compare
25bfdaa to
7a8b730
Compare
b34aa87 to
653fc0e
Compare
7a8b730 to
7b69e3b
Compare
c26138a to
a16cf66
Compare
653fc0e to
8743326
Compare
b5a794a to
ac38662
Compare
a16cf66 to
5c34ba0
Compare
ac38662 to
0cfd982
Compare
5c34ba0 to
c433056
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
0cfd982 to
ccbd1b2
Compare
| * | ||
| * @module | ||
| */ | ||
| export { sentryBunPlugin } from '@sentry/server-utils/orchestrion/bun'; |
There was a problem hiding this comment.
l/m: why does this implementation need to live in the server-utils package? It seems to me it would make sense to have the platform-specific implementations in the respective packages, so the bun plugin in the sentry/bun package, the node one in sentry/node, etc?
There was a problem hiding this comment.
Isn't it better to have the actual implementation all in the same place?
There was a problem hiding this comment.
Hm, I had put it there because I'd moved the vite plugin there, so it felt easy to just put it side by side.
But maybe that actually doesn't make sense? The Deno and Node runtime imports are in their respective packages (but they're also basically one-liners).
So, yeah, I think it probably makes the most sense to move this into the Bun package, rather than having a basically empty re-export, and move the packages/server-utils/src/orchestrion/bundler/vite.ts away if it turns out there's no need for it there. I'm going to make that change 👍
c433056 to
1551113
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
ccbd1b2 to
33c961c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 33c961c. Configure here.
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
33c961c to
58c4c54
Compare
1551113 to
5551e89
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
58c4c54 to
942cbc7
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
942cbc7 to
b7d3bf4
Compare
5551e89 to
df94b15
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
b7d3bf4 to
5b4cb48
Compare
df94b15 to
fa84662
Compare
Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in `bun build` mode. Note: this does *not* provide a plugin for use with `bun run`, because that feature is blocked by oven-sh/bun#31770 When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.
5b4cb48 to
cfe1a03
Compare

Use the orchestrion plugin defined in server-utils, and create a plugin that Bun can use in
bun buildmode.Note: this does not provide a plugin for use with
bun run, because that feature is blocked by oven-sh/bun#31770When that issue resolves, we can look into providing this for the bun runtime, likely with a version guard to avoid the footgun of removing CommonJS exports in some cases.