fix: exclude SentrySqlListener from .NET Framework builds#5236
Draft
jamescrosswell wants to merge 1 commit into
Draft
fix: exclude SentrySqlListener from .NET Framework builds#5236jamescrosswell wants to merge 1 commit into
jamescrosswell wants to merge 1 commit into
Conversation
SqlClient's DiagnosticSource integration does not work on .NET Framework (see dotnet/SqlClient#1529), so compiling SentrySqlListener into the net462 target was misleading. Wrap it and its subscriber wiring with #if !NETFRAMEWORK guards. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5236 +/- ##
==========================================
+ Coverage 74.12% 74.13% +0.01%
==========================================
Files 508 508
Lines 18282 18282
Branches 3574 3574
==========================================
+ Hits 13551 13553 +2
+ Misses 3861 3860 -1
+ Partials 870 869 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlClient's DiagnosticSource-based events are not delivered on .NET Framework (see dotnet/SqlClient#1529), so including
SentrySqlListenerin thenet462package is misleading — it compiles and registers but silently does nothing.SentrySqlListenerentirely in#if !NETFRAMEWORKSqlClientDiagnosticListenersubscription inSentryDiagnosticSubscriberwith the same guardSentrySqlListenerExtensionsandSentrySqlListenerTestsfrom .NET Framework test buildsAll existing tests pass unchanged on
net9.0.#skip-changelog
Closes #3173