feat(android): expose tombstone options via SentryOptions.Native#5226
Open
jamescrosswell wants to merge 3 commits into
Open
feat(android): expose tombstone options via SentryOptions.Native#5226jamescrosswell wants to merge 3 commits into
jamescrosswell wants to merge 3 commits into
Conversation
Adds TombstoneEnabled and ReportHistoricalTombstones to SentryOptions.NativeOptions and bindable Android native options, then maps them to SentryAndroidOptions. Closes #5027 Co-Authored-By: Justice <agent-noreply@example.com>
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Use ReportHistoricalTombstones instead of ReportHistoricalAnrs when applying NativeOptions.ReportHistoricalTombstones. Co-Authored-By: Justice <agent-noreply@example.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5226 +/- ##
==========================================
+ Coverage 74.06% 74.13% +0.07%
==========================================
Files 501 508 +7
Lines 18113 18282 +169
Branches 3521 3574 +53
==========================================
+ Hits 13415 13553 +138
- Misses 3838 3860 +22
- Partials 860 869 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f995180. Configure here.
Set Native.TombstoneEnabled and Native.ReportHistoricalTombstones defaults to false, and update XML docs to match Java SDK behavior. Co-Authored-By: Justice <agent-noreply@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TombstoneEnabledandReportHistoricalTombstonestoSentryOptions.NativeOptions(Android)BindableSentryOptions.NativeOptionsApplyToSentryAndroidOptionsduring Android SDK initWhy
Implements #5027 by exposing Android Java SDK tombstone controls through .NET native options.
Testing
dotnet build src/Sentry/Sentry.csproj -f net9.0-android35.0 -v minimaldotnet test test/Sentry.Tests/Sentry.Tests.csproj -f net9.0-android35.0 --no-restore --filter "FullyQualifiedName~Platforms.Android.BindableNativeOptionsTests" -v normalCloses #5027