ci: update the Update Dependencies workflow#5175
Conversation
| # And on every PR merge so we get the updated dependencies ASAP, and to make sure the changelog doesn't conflict. | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
question: add or revert?
It's part of the template/example: https://github.com/getsentry/github-workflows/tree/main/updater
On the one hand, we do daily updates already,
on the other hand, it wouldn't really hurt either.
There was a problem hiding this comment.
Every push seems like an odd/arbitrary trigger. I think daily is fine.
| with: | ||
| name: ${{ matrix.name }} | ||
| path: ${{ matrix.path }} | ||
| ssh-key: ${{ secrets.CI_DEPLOY_KEY }} |
There was a problem hiding this comment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5175 +/- ##
==========================================
- Coverage 74.13% 74.12% -0.01%
==========================================
Files 508 508
Lines 18282 18282
Branches 3574 3574
==========================================
- Hits 13553 13552 -1
Misses 3860 3860
- Partials 869 870 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I see the issue this is supposed to resolve is closed alread: Is this still required? |
Not strictly required any longer, to be fair. And I removed a part of a comment about "resolving CHANGELOG conflicts", as we do auto-generate them now though Craft. |
3 participants
fixes #5166actually fixed via
This change is restricting the permissions ... updating to what's recommended at https://github.com/getsentry/github-workflows/tree/main/updater